Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to match Flutter 3.22 #2193

Merged
merged 13 commits into from
May 20, 2024
Merged

Bump dependencies to match Flutter 3.22 #2193

merged 13 commits into from
May 20, 2024

Conversation

piotruela
Copy link
Collaborator

Upcoming version of Flutter depends on test_api 0.7.0. It also makes duration and phase parameters in pumpWidget method named so we have to adjust or implementation of patrol_finders and bump the dependencies.

@piotruela piotruela requested a review from zltnDC May 13, 2024 20:04
@github-actions github-actions bot added the package: patrol Related to the patrol package (native automation, test bundling) label May 13, 2024
@github-actions github-actions bot added package: adb Related to the adb package package: patrol_cli Related to the patrol_cli package labels May 14, 2024
@rydmike
Copy link

rydmike commented May 14, 2024

@piotruela,

Will you release the 2.0.3-dev.1 version as 2.0.3 soonish with the Flutter 3.22 pumpWidget support? Got some tests not running on Flutter 3.22 due to this. Thanks in advance.

Copy link

@rishabnayak rishabnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piotruela appears you might need to bump flutter to 3.22.0 here

@github-actions github-actions bot added the cirrusci Mark a PR with this label to run CirrusCI on it label May 15, 2024
@piotruela
Copy link
Collaborator Author

@piotruela,

Will you release the 2.0.3-dev.1 version as 2.0.3 soonish with the Flutter 3.22 pumpWidget support? Got some tests not running on Flutter 3.22 due to this. Thanks in advance.

@rydmike
Do you mean that the 2.0.3-dev.1 version doesn't work for you? What exactly is the problem there?

@rydmike
Copy link

rydmike commented May 15, 2024

It certainly works and I used it, but I would prefer to not depend on a .dev release, especially not in another package. However, since it is only a dev/test dependency I did. :)

But the released none dev version of your package now no longer works at all with the latest stable Flutter 3.22 release, so it should be bumped.

@piotruela piotruela merged commit 9c0dc93 into master May 20, 2024
14 of 17 checks passed
@piotruela piotruela deleted the chore/deps branch May 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cirrusci Mark a PR with this label to run CirrusCI on it package: adb Related to the adb package package: patrol_cli Related to the patrol_cli package package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants