Fix/scrolling rework #1325
Merged
Fix/scrolling rework #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
github-actions
bot
added
the
package: patrol
bartekpacia
reviewed
May 30, 2023
|
Let's add a link to the issue in the PR description @jBorkowska |
This was referenced Jun 1, 2023
bartekpacia
reviewed
Jun 2, 2023
jBorkowska
force-pushed
the
fix/scrolling-rework
branch
from
3ffb7ff to
b696bbd
Compare
jBorkowska
force-pushed
the
feature/maybe-settle
branch
from
9270573 to
88bce1c
Compare
jBorkowska
force-pushed
the
fix/scrolling-rework
branch
from
b696bbd to
13c1983
Compare
bartekpacia
reviewed
Jun 13, 2023
jBorkowska
force-pushed
the
feature/maybe-settle
branch
from
88bce1c to
3658393
Compare
jBorkowska
force-pushed
the
fix/scrolling-rework
branch
from
13c1983 to
43f2640
Compare
bartekpacia
reviewed
Jun 19, 2023
| if (iterationsLeft <= 0) { | ||
| throw WaitUntilExistsTimeoutException( | ||
| finder: finder, | ||
| // TODO: set reasonable duration |
There was a problem hiding this comment.
It's because I couldn't figure out what we should log here, bc we weren't waiting explicitly. And I still don't know what to put here.
Maybe we should implement separate exception for this situation.
bartekpacia
reviewed
Jun 19, 2023
bartekpacia
reviewed
Jun 19, 2023
| if (iterationsLeft <= 0) { | ||
| throw WaitUntilVisibleTimeoutException( | ||
| finder: finder.hitTestable(), | ||
| // TODO: set reasonable duration |
bartekpacia
reviewed
Jun 19, 2023
bartekpacia
reviewed
Jun 19, 2023
bartekpacia
approved these changes
Jun 19, 2023
bartekpacia
force-pushed
the
feature/maybe-settle
branch
from
2702fe6 to
d851f44
Compare
jBorkowska
force-pushed
the
fix/scrolling-rework
branch
from
7fca181 to
639e997
Compare
jBorkowska
force-pushed
the
fix/scrolling-rework
branch
from
639e997 to
c83d120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1323