Allow usage of a forbidden item in a hide combinator (#352)

* Allow usage of a forbidden item in a `hide` combinator * Release leancode_lint v14.1.0 * Check isInHide once per node
leancodepl · Sep 2, 2024 · 759193b · 759193b
1 parent feab933
commit 759193b
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 2 deletions.
diff --git a/packages/leancode_lint/CHANGELOG.md b/packages/leancode_lint/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 14.1.0
+
+- Allow usage of a forbidden item in a `hide` combinator in `use_design_system_item`
+
 # 14.0.0
 
 - Enable the following lints:

diff --git a/packages/leancode_lint/lib/lints/use_instead_type.dart b/packages/leancode_lint/lib/lints/use_instead_type.dart
@@ -80,6 +80,10 @@ abstract base class UseInsteadType extends DartLintRule {
     Element element,
     AstNode node,
   ) {
+    if (_isInHide(node)) {
+      return;
+    }
+
     for (final (preferredItemName, checker) in _checkers) {
       try {
         if (checker.isExactly(element)) {
@@ -96,4 +100,15 @@ abstract base class UseInsteadType extends DartLintRule {
       }
     }
   }
+
+  bool _isInHide(AstNode node) {
+    if (node.parent case final parent?) {
+      if (parent is HideCombinator) {
+        return true;
+      }
+      return _isInHide(parent);
+    } else {
+      return false;
+    }
+  }
 }
diff --git a/packages/leancode_lint/pubspec.yaml b/packages/leancode_lint/pubspec.yaml
@@ -1,5 +1,5 @@
 name: leancode_lint
-version: 14.0.0
+version: 14.1.0
 homepage: https://github.com/leancodepl/flutter_corelibrary/tree/master/packages/leancode_lint
 repository: https://github.com/leancodepl/flutter_corelibrary
 description: Robust, high-quality lint rules used at LeanCode.

diff --git a/packages/leancode_lint/test/lints_test_app/analysis_options.yaml b/packages/leancode_lint/test/lints_test_app/analysis_options.yaml
@@ -11,6 +11,9 @@ custom_lint:
       LftScaffold:
         - instead_of: Scaffold
           from_package: flutter
+      LftPlaceholder:
+        - instead_of: Placeholder
+          from_package: flutter
     - prefix_widgets_returning_slivers:
       application_prefix: Lncd
     # TODO: remove explicit enable once enabled by default

diff --git a/packages/leancode_lint/test/lints_test_app/lib/use_design_system_item_test.dart b/packages/leancode_lint/test/lints_test_app/lib/use_design_system_item_test.dart
@@ -1,7 +1,10 @@
 // for tests
 // ignore_for_file: unused_local_variable
 
-import 'package:flutter/material.dart';
+import 'package:flutter/material.dart'
+// `Placeholder` is forbidden, we check that no lint is raised for a `hide`
+    hide
+        Placeholder;
 
 class SampleWidget extends StatelessWidget {
   const SampleWidget({super.key});