Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests.yml add PHP 8.4 #271

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update tests.yml add PHP 8.4 #271

merged 1 commit into from
Nov 27, 2024

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Nov 27, 2024

Actually show deprecated warnings

Released 21 Nov 2024.
https://www.php.net/releases/8.4/en.php

leaf: 2024/11/27 13:43:04 [error] 30#30: *1 FastCGI sent in stderr: "PHP message: PHP Deprecated: Leaf\Exception\Run::__construct(): Implicitly marking parameter $system as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/exception/src/Exception/Run.php on line 70; PHP message: PHP Deprecated: {closure:Leaf\Exception\Handler\PrettyPageHandler::addDataTableCallback():386}(): Implicitly marking parameter $inspector as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/exception/src/Exception/Handler/PrettyPageHandler.php on line 386; PHP message: PHP Deprecated: Leaf\Exception\Util\TemplateHelper::render(): Implicitly marking parameter $additionalVariables as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/exception/src/Exception/Util/TemplateHelper.php on line 237; PHP message: PHP Deprecated: Leaf\Http\Request::params(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/http/src/Request.php on line 237; PHP message: PHP Deprecated: Leaf\Http\Request::getOrDefault(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/http/src/Request.php on line 253; PHP message: PHP Deprecated: Leaf\Http\Request::cookies(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/http/src/Request.php on line 303; PHP message: PHP Deprecated: Leaf\Http\Response::download(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/http/src/Response.php on line 189; PHP message: PHP Deprecated: Leaf\Http\Response::withCookie(): Implicitly marking parameter $expire as nullable is deprecated, the explicit nullable type must be used instead in /leaf/vendor/leafs/http/src/Response.php on line 359;

Actually show deprecated warnings
@mychidarko mychidarko merged commit 6d7069d into leafsphp:v3.x Nov 27, 2024
18 checks passed
@joanhey joanhey deleted the patch-1 branch November 27, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants