Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JEI request search to crafting teaching window #10471

Open
wants to merge 2 commits into
base: version/main
Choose a base branch
from

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Nov 20, 2024

Reopens #10438

Changes proposed in this pull request

  • Adds a "requests" button to the crafting and furnace teaching GUIs.
    image
    • Clicking the button shows the list of current clipboard item requests.
      • If a request accepts multiple items, only the first item is shown.
      • It does not show DO-only blocks, since those are known to be handled elsewhere.
      • It does not otherwise filter the requests, since I couldn't think of a good way to do that (validity depends on input ingredients too, which aren't known yet).
    • Clicking "select" on a request will try to open JEI to a recipe for that item.
    • If you happen to be on the right page (or switch to it) for the underlying craft (i.e. crafting table or furnace) then you can click the Plus button to transfer the recipe to the teaching grid (as you could before).
  • No button was added to the potion brewing GUI -- there's no technical reason this couldn't happen but it seemed less useful as it's less likely for there to be requests for potions outside of explicit player setup anyway.
  • The button is also not shown on the 2x2 crafters (builder and miner) because there isn't a good way to limit it to only show 2x2-capable recipes, so it seemed more noisy than helpful.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (do not port; this will need changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant