Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortress, medieval and Ancient athens fixes #10415

Open
wants to merge 2 commits into
base: version/main
Choose a base branch
from

Conversation

MotionlessTrain
Copy link
Contributor

@MotionlessTrain MotionlessTrain commented Nov 6, 2024

Closes #
Closes #

Changes proposed in this pull request

  • Followup to Medieval and Fortress fixes and Shire and Fortress rebalancing in 1.20.1 #10364.
    In the fix of the decorations not being shown as levellable in the build tool, it turned out that the decoration controller broke,
    as I forgot to set a pack in the fixed decorations. I thought including a path and schematicName would be enough to tell the decoration controller to not use the legacy code anymore, but it was looking at the pack NBT-component instead.
  • I've been thinking about removing the legacy code in TileEntityDecorationController as well,
    as the decorations for which that was still needed should now all be migrated. But I wasn't sure whether that would be better in a separate PR

    Edit: I didn't check whether it would be needed in Stylecolonies, as a few styles there (at least Frontier) stems from before 1.19
  • Move the medium_military harbour pier decoration in Ancient athens to the correct folder

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@MotionlessTrain MotionlessTrain changed the title Fortress and medieval fixes Fortress, medieval and Ancient athens fixes Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant