Fortress, medieval and Ancient athens fixes #10415
Open
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
In the fix of the decorations not being shown as levellable in the build tool, it turned out that the decoration controller broke,
as I forgot to set a pack in the fixed decorations. I thought including a path and schematicName would be enough to tell the decoration controller to not use the legacy code anymore, but it was looking at the pack NBT-component instead.
I've been thinking about removing the legacy code in TileEntityDecorationController as well,as the decorations for which that was still needed should now all be migrated. But I wasn't sure whether that would be better in a separate PR
Edit: I didn't check whether it would be needed in Stylecolonies, as a few styles there (at least Frontier) stems from before 1.19
Testing
Review please