Concrete mixer can do multiple things before going back to the hut #10331
Conversation
| int size = 0; | ||
| for (List<BlockPos> positions : waterPos.values()) | ||
| { | ||
| size += positions.size(); |
There was a problem hiding this comment.
The positions stored in the map contain the depth as the key, and the positions of the water at the given level.
By the way the code looks it's technically allowed to have several water streams at the same time, there's no practical limit on this.
| { | ||
| for (final BlockPos pos : waterPos.getOrDefault(i, Collections.emptyList())) | ||
| { | ||
| final BlockState state = colony.getWorld().getBlockState(pos); | ||
| if (!state.getFluidState().isEmpty() && state.getBlock() == Blocks.WATER) | ||
| if (state.is(Blocks.WATER)) |
There was a problem hiding this comment.
flowing water is not water though
There was a problem hiding this comment.
Well I tested this, and it is.
If a block contains flowing water the block is still marked as containing water, the fluid state however just lists a different water depth.
There's no need for a depth check because the waterPos already has determined the required water level should be good in the schematic.
There was a problem hiding this comment.
Please double check this. Because at least in some cases as far as I am aware, if air gets some low level water into it, it's fluidstate not empty, but actual state is not water.
Closes #10209
Changes proposed in this pull request
Testing
Review please