Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for water bucket #10087

Open
wants to merge 5 commits into
base: version/main
Choose a base branch
from

Conversation

TheNumenorean
Copy link

@TheNumenorean TheNumenorean commented Aug 2, 2024

Changes proposed in this pull request:

Allow baker to fill buckets at the same level they can fill bottles.

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Thodor12
Copy link
Contributor

Thodor12 commented Aug 2, 2024

Hello, thanks for the contribution.
Merely adding a data generator is not sufficient, you also have to execute runData to actually generate the json files

@TheNumenorean
Copy link
Author

Done, i believe. Is there any documentation on the process though?

@Thodor12
Copy link
Contributor

Thodor12 commented Aug 3, 2024

Done, i believe. Is there any documentation on the process though?

Yes, although this is common Forge knowledge. You can read that here:
https://docs.minecraftforge.net/en/1.20.x/datagen/

@TheNumenorean
Copy link
Author

Its been a while, thanks.

@uecasm
Copy link
Contributor

uecasm commented Aug 4, 2024

Speaking of level requirements: the baker was originally restricted to level 3 for water bottles mainly because that's when they started needing them for their own recipes. But now they can fill large water bottles at level 1. Does it still make sense to restrict small water bottles to level 3? And likewise for water buckets? Or is it the large bottles that are wrong here?

@Raycoms
Copy link
Contributor

Raycoms commented Aug 4, 2024

Speaking of level requirements: the baker was originally restricted to level 3 for water bottles mainly because that's when they started needing them for their own recipes. But now they can fill large water bottles at level 1. Does it still make sense to restrict small water bottles to level 3? And likewise for water buckets? Or is it the large bottles that are wrong here?

I think that's fine.

@fjmacagno
Copy link

Is that to say you want me to change the level req to 1?

@Raycoms
Copy link
Contributor

Raycoms commented Aug 5, 2024

Is that to say you want me to change the level req to 1?

No it's fine

@TheNumenorean
Copy link
Author

Is there anything you need from me prior to one of you merging this? I don't believe i have the permissions to get TC to re-trigger, given it doesn't seem to have automatically.

@TheNumenorean
Copy link
Author

Would someone mind merging this?

@TheNumenorean
Copy link
Author

Bump. @Raycoms @Thodor12

@Raycoms
Copy link
Contributor

Raycoms commented Sep 5, 2024

Bump. @Raycoms @Thodor12

Still requiring another maintainer approval.

@TheNumenorean
Copy link
Author

Is there anything i can do to help that along?

@TheNumenorean
Copy link
Author

@someaddons bump on a review?

@TheNumenorean
Copy link
Author

Monthly bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants