Delegating all possible props to ViewTransformer #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for the project, it is really helpful! It saved me a lot of time.
As you said, this project is a layer over https://github.com/ldn0x7dc/react-native-view-transformer so it can be painful to keep both interfaces in sync. This commit delegates to view transformer all possible props.
The reason I need this modification is that to fit the UX I desire I need to modify maxScale and maxOverScrollDistance. View transformer is so powerful, I believe exposing its full interface will be a great improvement to react-native-transformable-image users.
Cheers!