-
-
Notifications
You must be signed in to change notification settings - Fork 267
Prepare DtoCallFunction() for runtime function calls #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A first step towards calling runtime functions with the
|
Nice that you are working on the follow-up to #1208 ! |
TypeFunction *const tf = DtoTypeFunction(fnval); | ||
|
||
const size_t numArguments = arguments ? arguments->dim : 0; | ||
std::vector<DValue *> argvals(numArguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you can use llvm::SmallVector here (number of arguments is usually small I'd think).
Could you incorporate Johan's suggestions and rebase, please? |
I'm not a huge fan of I still need to figure out how to structure the logging, as the args are currently evaluated outside the |
Yeah, forget about my comments :) |
Rebase on ltsmaster and merge? |
Finally rebased incl. taking care of logging. |
By also accepting DValue args, not just Expressions.
…1238) By also accepting DValue args, not just Expressions.
By also taking
DValue*
args, not justExpression*
s.