force socket to be closed on destroy

[dfit99]

This will force destroy a socket after calling destroy.
Fixing the file descriptor leak issue, see #605

[UziTech]

Can you write a test for this?

[dfit99]

Hi Tony,

Thanks for the quick reply, do you have any suggestions on where to add the tests to and what exactly to test?
There aren't any contribution guidelines I could find.

[UziTech]

You can write the test in /test/client.test.js. Try to find a test that does something similar and copy it.

[dfit99]

I added some tests

[UziTech]

LGTM

[dfit99]

@UziTech Thank you for approving.
Can you please merge this in -- it says "Only those with [write access]) to this repository can merge pull requests."

[dfit99]

@UziTech Just following up here, are there plans to merge this in?
I ask because this is a critical issue for my team (the memory leaked caused some of our production processes to crash) and would ideally not have to use a forked version of this library.

Sorry for rushing you and thanks again for reviewing my PR :)

[jsumners]

@UziTech Just following up here, are there plans to merge this in? I ask because this is a critical issue for my team (the memory leaked caused some of our production processes to crash) and would ideally not have to use a forked version of this library.

Sorry for rushing you and thanks again for reviewing my PR :)

Releases are issued according to the maintainers's available time and desire to work on the project.

[jsumners]

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.