introduce helpers.uri (curl replacement) & migrate widget/weather to it #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razamatan
force-pushed
the
soup
branch
2 times, most recently
from
f09f442
to
56025dc
Compare
|
re: globals. yeah, i'll break out the breaking global var change into a different pr. |
|
see #349 (comment). i'm going to go ahead and break out the global change to a later pr to unblock this one. |
|
updated. went ahead and did the global state localization for the weather widget in this pr since this is a breaking change anyway. i'll have different PRs for some of the other widgets i mess with. |
razamatan
added a commit
to razamatan/lain
that referenced
this pull request
Jan 20, 2023
- going forward, there are a couple of ways to access state from
the settings callbacks
- `settings` functions should always take in `widget` and `now` as the
arguments. so the signature is `settings = function(widget, now)`
- use `foo.widget` and `foo.now` to access the awesome widget and
current state (respectively) of `foo` widget
- weather has been done in lcpz#549
- sysload's state is now in a `now` table. access the 1, 5 and 15 min
load averages via `now[1]`, `now[5]`, and `now[15]`
- the bat and contrib/tp_smapi widgets have NOT been migrated as i do
not have a laptop to verify behaviors
razamatan
added a commit
to razamatan/lain
that referenced
this pull request
Jan 20, 2023
- going forward, there are a couple of ways to access state from
the settings callbacks
- `settings` functions should always take in `widget` and `now` as the
arguments. so the signature is `settings = function(widget, now)`
- use `foo.widget` and `foo.now` to access the awesome widget and
current state (respectively) of `foo` widget
- weather has been done in lcpz#549
- sysload's state is now in a `now` table. access the 1, 5 and 15 min
load averages via `now[1]`, `now[5]`, and `now[15]`
- the bat and contrib/tp_smapi widgets have NOT been migrated as i do
not have a laptop to verify behaviors
- new dependency: needs libsoup gi installation (smaller than gvfs) - [breaking] weather: `(current/|forecast)_call` changed to `(current|forecast)_uri` - [breaking] weather: use scoped (non-global) `now.current` and `now.forecast` to avoid `weather_now` clobbering. see lcpz#550 for more details. - weather: display something useful by default - weather: render the hour of the forecast by default since the default forecast is 5 days by 3h increments - weather: add degree symbol to temperatures by default
razamatan
added a commit
to razamatan/lain
that referenced
this pull request
Jan 20, 2023
- going forward, there are a couple of ways to access state from
the settings callbacks
- `settings` functions should always take in `widget` and `now` as the
arguments. so the signature is `settings = function(widget, now)`
- use `foo.widget` and `foo.now` to access the awesome widget and
current state (respectively) of `foo` widget
- weather has been done in lcpz#549
- sysload's state is now in a `now` table. access the 1, 5 and 15 min
load averages via `now[1]`, `now[5]`, and `now[15]`
- the bat and contrib/tp_smapi widgets have NOT been migrated as i do
not have a laptop to verify behaviors
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(current/|forecast)_callchanged to(current|forecast)_urinow.currentandnow.forecastto avoidweather_nowclobbering