-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect MADS/RDF assertions for Persons as subjects #237
Comments
Thanks for this, Tim. This is a known issue (but good to have it tracked here) and slated for clean up in the next release or two. FWIW, the plan is to comb through the conversions - this one and bf2m - and sort this out completely. |
I think some of this is addressed already in v2.5. We no longer link to authorities/names, using instead the rwo. So take a look at this where Mark Twain is the subject:
I"m not saying we're done, but we've started. |
Ah, interesting. So, it works for label lookups but not yet with existing $0 IRIs |
We can manipulate the BF when it exits via ID, which is what you are seeing in Nate's example, but this is, at heart, a conversion issue. The ID code is flipping things into the correct, or at least a better, shape. The raw conversion output pretty much looks like the example above: <bf:subject>
<bf:Agent rdf:about="http://id.loc.gov/resources/REPLACE/13621412#Agent600-19">
<rdf:type rdf:resource="http://id.loc.gov/ontologies/bibframe/Person"/>
<rdf:type rdf:resource="http://www.loc.gov/mads/rdf/v1#PersonalName"/>
<madsrdf:authoritativeLabel>Twain, Mark, 1835-1910</madsrdf:authoritativeLabel>
<madsrdf:isMemberOfMADSScheme rdf:resource="http://id.loc.gov/authorities/subjects"/>
<bflc:marcKey>60010$aTwain, Mark,$d1835-1910.</bflc:marcKey>
<rdfs:label>Twain, Mark, 1835-1910</rdfs:label>
<bf:source rdf:resource="http://id.loc.gov/authorities/subjects"/>
</bf:Agent>
</bf:subject> |
Scenario
When a subject field with a personal name and LCNAF IRI in $0 is converted, the following output is produced:
Issues
bf:source
assertion.Expectation
The converted output should look more like this:
Source record
The text was updated successfully, but these errors were encountered: