Export only public symbols #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless function is declared by an installed header, it should be marked either LCM_NO_EXPORT or static. Running 'nm --extern-only --defined-only liblcm.so' will show the exported symbols. As of these commit, the only text (i.e., function) symbols are the 16 necessary API functions; previously, there were 83.
Curiously, this doesn't reproduce on the cmake build (I tried macOS and Linux, clang and gcc, debug and release build). But this is definitely true for the meson build |
|
Ah, interesting, I hadn't noticed that. Looking now, I see that the generated Lines 50 to 53 in f6f09bc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless a function is declared by an installed header, it should be marked either LCM_NO_EXPORT or static.
Running 'nm --extern-only --defined-only liblcm.so' will show the exported symbols. As of these commit, the only text (i.e., function) symbols are the 16 necessary API functions; previously, there were 83.