Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update mandatenbeheer tegels #408

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

wolfderechter
Copy link
Contributor

@wolfderechter wolfderechter commented Aug 27, 2024

ID

DL-6046

Description

Adds a feature flag to toggle the existing mandatenbeheer tile, as well as adding a new mandatenbeheer tile for the external mandatenbeheer application.

docker-compose.override.yml for PROD:

EMBER_MANDATENBEHEER_EXTERNAL_URL: "mandatenbeheer.lokaalbestuur.vlaanderen.be

docker-compose.override.yml for QA:

EMBER_MANDATENBEHEER_EXTERNAL_URL: "https://mandatenbeheer.lblod.info/"

docker-compose.override.yml for DEV:

EMBER_MANDATENBEHEER_EXTERNAL_URL: "https://dev.mandatenbeheer.lblod.info/"

Make sure to add the following environment variable for the existing mandatenbeheer tile:

EMBER_MANDATENBEHEER: "true"

To disable the tile, simply change the value to false.

Note: no redirect logic was implemented since the new mandatenbeheer application is too different, so wasn't worth the effort.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

@Windvis
Copy link
Contributor

Windvis commented Aug 27, 2024

This should be good to go once you run Prettier locally 👍

@Windvis Windvis added the enhancement New feature or request label Aug 27, 2024
@Windvis Windvis merged commit 54cfe89 into development Aug 28, 2024
2 checks passed
@Windvis Windvis deleted the feat/add-external-mandatenbeheer-tile branch August 28, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants