Replace <WuDatepicker> with <AuDatePicker> #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
commented
Apr 20, 2021
Windvis
commented
Apr 20, 2021
Windvis
commented
Apr 20, 2021
Windvis
commented
Apr 20, 2021
| @@ -56,7 +56,7 @@ | |||
|
|
|||
| // WU COMPONENTS (DEPRECATED) | |||
| @import 'ember-vo-webuniversum'; | |||
| @import 'ember-vo-webuniversum-data-table'; | |||
| // @import 'ember-vo-webuniversum-data-table'; // This imports the ember-data-table styles which make <duet-date-picker> not render correctly | |||
There was a problem hiding this comment.
This conflicted with the styles of the date picker. I think it can just be removed though. Everything seems to be converted to AuDataTable already?
There was a problem hiding this comment.
@Dietr can you confirm we no longer need these styles? (I didn't see anything of so I assume they are no longer used)
There was a problem hiding this comment.
There was a small issue with the meeting tables but added a fix for that
Windvis
commented
Apr 20, 2021
Windvis
commented
Apr 20, 2021
|
Blocked until I finish the Appuniversum work. |
Windvis
force-pushed
the
chore/replace-vo-datepicker
branch
2 times, most recently
from
46fb707
to
7777af0
Compare
|
Reworked the PR based on the changes done in ember-appuniversum. Once that one is merged / released this PR can be unblocked by bumping the version. |
Windvis
force-pushed
the
chore/replace-vo-datepicker
branch
from
7777af0
to
4f68659
Compare
Windvis
commented
Apr 29, 2021
nvdk
approved these changes
Apr 29, 2021
v5.2.0 includes a feature that makes getters that use intl service methods rerun when the locale changes. More info: ember-intl/ember-intl#1071
Windvis
force-pushed
the
chore/replace-vo-datepicker
branch
from
4f68659
to
3682eb0
Compare
Dietr
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the ember-appuniversum update commit from #95 as well to make it easier to test.