Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize meeting page css #786

Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 3, 2024

Overview

This PR slightly modernizes the meeting page css by moving to a flex-based layout.
In terms of UX/UI the behaviour should have stayed more-or-less the same.

connected issues and PRs:

None

Setup

None

How to test/reproduce

  • Login as a municipality and open/create a meeting
  • Both the behaviour of the sidebar and main content should have stayed the same:
    • Both containers scroll independently
    • Paddings have remained the same/similar
    • The page is still more-or-less responsive: the sidebar disappears when reducing the width of the page + the main section takes full width

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma requested a review from abeforgit December 3, 2024 18:13
@abeforgit abeforgit merged commit 33cf660 into GN-5304-auto-connect-articles-on-ap-init Dec 3, 2024
3 checks passed
@abeforgit abeforgit deleted the fix/meeting-page-css branch December 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants