Embroider optimized support #964
Conversation
Windvis
force-pushed
the
embroider-optimized-fixes
branch
2 times, most recently
from
042d14c
to
aa569af
Compare
| import { Node as PNode } from 'prosemirror-model'; | ||
|
|
||
| const emberNodeConfig: EmberNodeConfig = { | ||
| name: 'image', | ||
| componentPath: 'plugins/image/node', | ||
| component: Image as unknown as ComponentLike, |
There was a problem hiding this comment.
It seems there are type conflicts between our components and the ComponentLike type from @glint/template. Not sure what is up exactly, maybe outdated type packages. More investigation is needed. I used this workaround for now since TS isn't my forte 😬.
There was a problem hiding this comment.
I read through this issue and it does sound like we are doing the right thing with using ComponentLike<any> but I might be misunderstanding things.
There was a problem hiding this comment.
(I also asked in the discord, but haven't received a response yet.)
There was a problem hiding this comment.
Is the @glint/template package only added for the ComponentLike type?
There was a problem hiding this comment.
It could be possible that the types included with ember 5.0 are compatible with the glint types?
There was a problem hiding this comment.
Is the @glint/template package only added for the ComponentLike type?
Yes, that seemed to be the recommended way to type use-cases like that.
It could be possible that the types included with ember 5.0 are compatible with the glint types?
Yea, possibly, I haven't tried, but those are also not available on older versions so I don't think we can use them yet?
Windvis
force-pushed
the
embroider-optimized-fixes
branch
2 times, most recently
from
c5f529d
to
053d6ae
Compare
|
Should I enable the |
ember-velcro uses the "nested" component structure where an index.js are located in the `app/components/velcro/` folder. This no longer seems to work for v2 addons. As a workaround we can import the component and invoke it directly. This is also a transition path to .gts files.
The component was renamed a while ago but there were still some remnants around that caused issues under Embroider.
This replaces the `componentPath` with a `component` argument. Users need to provide the component class instead of the path which makes the setup Embroider compatible.
Windvis
force-pushed
the
embroider-optimized-fixes
branch
from
053d6ae
to
e2324a3
Compare
|
We're still figuring out how we're gonna manage the ember-try scenarios with woodpecker, so leave it off for now |
Overview
This should fix the remaining issues in #945 and make the addon fully Embroider "optimized" compatible.
connected issues and PRs:
Closes #945
Setup
How to test/reproduce
Run the embroider optimized scenario:
npx ember-cli try:one embroider-optimizedand the build should pass and the tests should succeed.If you want to run the dummy app you could run
npx ember-cli try:one embroider-optimized --skip-cleanupinstead and runEMBROIDER_TEST_SETUP_OPTIONS=optimized npm startafterwards.Challenges/uncertainties
Checks PR readiness