-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add election results for lists, not just candidates #221
Conversation
The model for this is very basic and is basically a hack to get this stuff to work
6cd9858
to
8d576b0
Compare
I'm a bit surprised by the structure, it seems you duplicate a lot of info we already have |
I did it this way to as much as possible separate this essentially unlinked data from the actual linked data in the triplestore. If we do the matching by names and create actual links from it, I worry that it will be mistaken for data that is based on something more than 'hey these names are the same, they must be the same'. So, I decided to do all the matching in the queries instead, so that it's clear where they're coming from. |
ok fair, but still I feel its a lot of data we don't need? like all the names and such |
we could also keep it in a separate graph to make sure we know where it's coming from |
I suppose I could remove the extra data. I included as I was worried that I'd need to do more to validate that I've got the correct result. I guess we should add back in if it turns out to be needed. |
still lots of duplicates:
|
I indeed understand not wanting to store this as linked data, as it is created by matching the names of the municipalities and candidate-lists. Of course, this is also (kind of) the way LMB must have converted it too linked-data, so... |
suggestion: if you preprocess the excel to have only one row per result we need,
you should then get the same count as the amount of rows in the excel I think |
6f37978
to
bd25789
Compare
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these migrations will work as expected. Just some side notes:
- We seem to be targetting fracties/kandidatenlijsten in general here, and not for a specific legislative period. This should however (in practice) not be a problem, as fractions/kandidatenlijsten of previous periods do not have the
ext:geproduceerdDoor
link, so we only target the next period anyway.
Add election results for lists, not just candidates
Overview
The model for this is very basic and is basically a hack to get this stuff to work. The results themselves come from extracting the relevant parts from a csv of the raw election results and processing them into a ttl. The only way to validate that the results are the expected ones is by matching multiple strings as we have no identifiers to compare to.
Draft as I'm unsure about the data and it needs a frontend release.
connected issues and PRs:
Jira ticket: https://binnenland.atlassian.net/browse/GN-5315
Corrects: lblod/frontend-gelinkt-notuleren#784
Frontend PR: lblod/frontend-gelinkt-notuleren#790.
Setup
Needs to be tested with a version of the frontend that uses the data.
How to test/reproduce
In the frontend, check that syncronisation works and produces the correct ordering based on fracties.
Challenges/uncertainties
Why do we not have this data in a linked format?!?
Checks PR readiness