Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LDB sync never clash with LMB data #218

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

abeforgit
Copy link
Member

Overview

We now unfortunately have to deal with 2 sources of truth when it comes to Person data (names in particular). We need to keep ingesting Person instances from the leidinggevenden database, because LMB does not track them, and there are many people which have a Functionaris instance, but no Mandataris instance (they are, after all, different jobs). However, there are some, (I count 31 at the time of the pr), where the same person has held both Functionaris and Mandataris positions throughout their career.

In that case, we have a possible clash of data, if LMB is updated without the corresponding update to LDB.

This pr makes it so that the LDB sync script never enters Person instances we already have from LMB. It only checks the public graph, but I've confirmed there are no instances of private Persons which are not also in the public graph.

As a side, this pr also flat out deletes the MDB sync script, as we really don't want to run that on accident, ever. Should we ever need it again, it's in the git history.

connected issues and PRs:

Setup

How to test/reproduce

Challenges/uncertainties

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@abeforgit abeforgit merged commit 7a60e28 into master Dec 3, 2024
@abeforgit abeforgit deleted the fix/ldb-sync-script branch December 3, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant