Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ldes-client): adjust tombstone handling #217

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 2, 2024

Overview

This PR includes some modifications in how we handle tombstone (deleted) resources in the lmb ldes-client.
Specifically this PR includes:

  • A migration which removes all outgoing and incoming triples related to tombstone resources, across all graphs
  • An adjustment to processPage.ts to remove incoming tombstones resources completely from our database (all related triples)
connected issues and PRs:

None

Setup

Ensure you have the ldes-client service set-up locally

How to test/reproduce

Scenario 1: starting from an empty database

  • Start virtuoso + migrations from scratch
  • Connect the ldes-client to your LMB environment of choice
  • Start the ldes-client and let it run (to completion)
  • Ensure that the triplestore does not contain any tombstone resources

Scenario 2: starting from a DEV/QA/PROD backup

  • Run the migration and ensure all tombstone resources (+ connected triples) are removed
  • The ldes-client should work as expected

Challenges/uncertainties

  • I used UNION instead of OPTIONAL as it is more performant
  • The migration needs a high ResultSetMaxRows to fully execute

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Dec 2, 2024
@elpoelma elpoelma requested a review from abeforgit December 2, 2024 12:16
@elpoelma elpoelma self-assigned this Dec 2, 2024
@abeforgit abeforgit merged commit 2b52222 into master Dec 2, 2024
@abeforgit abeforgit deleted the feat/improve-tombstone-handling branch December 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants