Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add daily iv report #216

Merged
merged 6 commits into from
Dec 3, 2024
Merged

add daily iv report #216

merged 6 commits into from
Dec 3, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Nov 28, 2024

Overview

Made a report about the number of IV created in each admin unit, and the number of those IVs that were synced

connected issues and PRs:

GN-5197

Setup

You will need a user to login into the dashboard

How to test/reproduce

reduce the cron on the ivReport file to make it run soon, verify that the cron is run and that the report generated is correct

Challenges/uncertainties

Waiting for a better translation for the report description and asked Arne if I should check if the synchronization was successful or not

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@lagartoverde lagartoverde self-assigned this Nov 28, 2024
Copy link
Contributor

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report generation itself works well.
A few questions/remarks though:

  • It seems that we always get all historical data, not only scoped per day. Is this what we want? Unfortunately, we of course don't keep track when a meeting has been created...
  • Unfortunately, we always only keep track of one 'sync-status' (through a belongsTo relationship), so the sync-count will always be 1 (per meeting). So I'm not sure if that statistic is super helpful. In hindsight (easy to say I know) we probably should have kept this as a hasMany relationship. The sync-status resources themselves are not removed I think, and as they are scoped per 'administrative-unit' graph, you might be able to get a relevant number still.
  • Indicating whether the sync was successful or not seems relevant to me

@lagartoverde
Copy link
Contributor Author

Report generation itself works well. A few questions/remarks though:

  • It seems that we always get all historical data, not only scoped per day. Is this what we want? Unfortunately, we of course don't keep track when a meeting has been created...
  • Unfortunately, we always only keep track of one 'sync-status' (through a belongsTo relationship), so the sync-count will always be 1 (per meeting). So I'm not sure if that statistic is super helpful. In hindsight (easy to say I know) we probably should have kept this as a hasMany relationship. The sync-status resources themselves are not removed I think, and as they are scoped per 'administrative-unit' graph, you might be able to get a relevant number still.
  • Indicating whether the sync was successful or not seems relevant to me
  1. My understanding is that we always want to get historical data
  2. The sync count will be always 1 in case that meeting was synced, otherwise it will be 0 my intention was to show how many of those IVs were synced
  3. How would you do it, make another column indicating if the last sync was an error?

@elpoelma
Copy link
Contributor

Report generation itself works well. A few questions/remarks though:

  • It seems that we always get all historical data, not only scoped per day. Is this what we want? Unfortunately, we of course don't keep track when a meeting has been created...
  • Unfortunately, we always only keep track of one 'sync-status' (through a belongsTo relationship), so the sync-count will always be 1 (per meeting). So I'm not sure if that statistic is super helpful. In hindsight (easy to say I know) we probably should have kept this as a hasMany relationship. The sync-status resources themselves are not removed I think, and as they are scoped per 'administrative-unit' graph, you might be able to get a relevant number still.
  • Indicating whether the sync was successful or not seems relevant to me
1. My understanding is that we always want to get historical data

2. The sync count will be always 1 in case that meeting was synced, otherwise it will be 0 my intention was to show how many of those IVs were synced

3. How would you do it, make another column indicating if the last sync was an error?

I would indeed indicate whether the last sync was an error in a seperate column.

@lagartoverde lagartoverde requested a review from elpoelma December 2, 2024 12:49
@abeforgit abeforgit merged commit 36fc42d into master Dec 3, 2024
@abeforgit abeforgit deleted the feat/iv-report branch December 3, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants