-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add daily iv report #216
add daily iv report #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Report generation itself works well.
A few questions/remarks though:
- It seems that we always get all historical data, not only scoped per day. Is this what we want? Unfortunately, we of course don't keep track when a meeting has been created...
- Unfortunately, we always only keep track of one 'sync-status' (through a
belongsTo
relationship), so the sync-count will always be 1 (per meeting). So I'm not sure if that statistic is super helpful. In hindsight (easy to say I know) we probably should have kept this as ahasMany
relationship. The sync-status resources themselves are not removed I think, and as they are scoped per 'administrative-unit' graph, you might be able to get a relevant number still. - Indicating whether the sync was successful or not seems relevant to me
|
I would indeed indicate whether the last sync was an error in a seperate column. |
Overview
Made a report about the number of IV created in each admin unit, and the number of those IVs that were synced
connected issues and PRs:
GN-5197
Setup
You will need a user to login into the dashboard
How to test/reproduce
reduce the cron on the ivReport file to make it run soon, verify that the cron is run and that the report generated is correct
Challenges/uncertainties
Waiting for a better translation for the report description and asked Arne if I should check if the synchronization was successful or not
Checks PR readiness