Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant file creation/write permission to accounts with 'Publiceerder' and 'Ondertekenaar' roles #214

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 18, 2024

Overview

This ensures that the following roles have the possibility to create/write http://www.semanticdesktop.org/ontologies/2007/03/22/nfo#FileDataObject objects:

  • GelinktNotuleren-publiceerder
  • GelinktNotuleren-ondertekenaar

This ensures that accounts with these roles, but without the 'Schrijver' role, have the option to sign and publish notulen.

How to test/reproduce

  • Start the app
  • Login as a 'Lezer' account
  • Open a meeting for which the 'notulen' have not been signed yet
  • Ensure you can add a first signature successfully
  • Ensure you can publish the notulen successfully

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Nov 18, 2024
@abeforgit abeforgit merged commit 6c26533 into fix/second-signature Nov 20, 2024
@abeforgit abeforgit deleted the fix/allow-file-creation branch November 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants