Skip to content

GN-5032: add migration which marks versioned-notulen as deleted if necessary #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Sep 6, 2024

Overview

This PR adds a migration which marks version-notulen resources as deleted if they are only linked to signed resources which are marked as deleted.

connected issues and PRs:

GN-5032
lblod/frontend-gelinkt-notuleren#710

Setup

Should be tested in combo with lblod/frontend-gelinkt-notuleren#710

How to test/reproduce

Check-out lblod/frontend-gelinkt-notuleren#710. This PR ensures that existing versioned-notulen resources are marked as deleted if necessary.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

… they are only linked to signed-resources which are marked as deleted
@abeforgit abeforgit merged commit c0eda5e into v5.16.x Sep 6, 2024
@abeforgit abeforgit deleted the GN-5032-signing-bug branch September 6, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants