Skip to content

Conversation

AntoineGautier
Copy link
Contributor

This closes #599.

@AntoineGautier
Copy link
Contributor Author

@karthikeyad-pnnl Can you check that this solves the issue we discussed a few weeks ago?

  • Check out this branch and the one from Fix plotting issues funnel#88
  • Uninstall buildingspy and pyfunnel from your Python environment.
  • Add the path to the local clone of BuildingsPy and funnel to PYTHONPATH.
  • Run unit tests on a package of MBL after modifying a validation model to trigger the plotting of the new trajectories.
  • Let me know if the execution still hangs or if you can proceed as expected.

@karthikeyad-pnnl
Copy link

@AntoineGautier I tested this out on both Linux and Windows. The unit tests run smoother now, and are no longer hanging up when the reference results change. Thanks for resolving this issue!

Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineGautier : Please go ahead and merge it once funnel is released as 1.0.3

@AntoineGautier
Copy link
Contributor Author

@karthikeyad-pnnl I've added new commits to fix #605.
Can you check again that this branch works well on your system, following the same steps as last time?

  • Check out this branch and the one from Fix plotting issues funnel#89
  • Uninstall buildingspy and pyfunnel from your Python environment.
  • Add the path to the local clone of BuildingsPy and funnel to PYTHONPATH.
  • Run unit tests on a package of MBL after modifying a validation model to trigger the plotting of the new trajectories.
  • Let me know if the execution still hangs or if you can proceed as expected.

@karthikeyad-pnnl
Copy link

@AntoineGautier Sorry I had completely missed this message. I updated my funnel and buildingspy packages to the latest development branches, and tested it on both Linux and Windows. The unit test is working as expected. Thanks for the updates!

@AntoineGautier
Copy link
Contributor Author

@mwetter This is ready to merge.
I think we can close #606 that is likely to be addressed with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix funnel plotting issues
3 participants