-
Notifications
You must be signed in to change notification settings - Fork 50
Fix plotting issues #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix plotting issues #600
Conversation
@karthikeyad-pnnl Can you check that this solves the issue we discussed a few weeks ago?
|
@AntoineGautier I tested this out on both Linux and Windows. The unit tests run smoother now, and are no longer hanging up when the reference results change. Thanks for resolving this issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
404b669
to
c90c628
Compare
c90c628
to
7f9277f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineGautier : Please go ahead and merge it once funnel is released as 1.0.3
@karthikeyad-pnnl I've added new commits to fix #605.
|
@AntoineGautier Sorry I had completely missed this message. I updated my funnel and buildingspy packages to the latest development branches, and tested it on both Linux and Windows. The unit test is working as expected. Thanks for the updates! |
3456b8a
to
ee9cf06
Compare
This closes #599.