Skip to content

Simple tests for UGRID cube printing. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbdreyer merged 1 commit into from
Mar 23, 2020
Merged

Simple tests for UGRID cube printing. #8

lbdreyer merged 1 commit into from
Mar 23, 2020

Conversation

@pp-mo
Copy link

@pp-mo pp-mo commented Mar 23, 2020

Suggested ultra-simple integration exercise of UGRID cube print strings.

@pp-mo pp-mo mentioned this pull request Mar 23, 2020
Merged
@lbdreyer
Copy link
Owner

lbdreyer commented Mar 23, 2020

This is just renaming test files? Is that what you meant @pp-mo ?

@pp-mo
Copy link
Author

pp-mo commented Mar 23, 2020

Is that what you meant @pp-mo ?

Ooops, no.
I forgot to "git add".
Hang on a mo ..

@pp-mo pp-mo force-pushed the pp__print_cube_ugrid branch from c9e16ee to 78378c9 Compare March 23, 2020 14:43
@pp-mo
Copy link
Author

pp-mo commented Mar 23, 2020

Here it is. Sorry for the delay !

lbdreyer
lbdreyer approved these changes Mar 23, 2020
View reviewed changes
Copy link
Owner

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo ! I'll merge this once the tests pass (just to be safe)

lbdreyer
lbdreyer reviewed Mar 23, 2020
View reviewed changes
lib/iris/tests/integration/ugrid/test_ugrid_summary.py
ugrid information:
Mesh0.node - - x
topology_dimension: 2
node_coordinates: latitude longitude
Copy link
Owner

@lbdreyer lbdreyer Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the test is failing on this line. It because these are contained in an unordered set (because there is not order inherent in the file, so to respect that and not to imply any order I just used a set). I could alphabetise them so that the results are consistent ?

Copy link
Owner

@lbdreyer lbdreyer Mar 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this in my branch (so I will merge this in the meantime), but I'd appreciate your thoughts on this ^ @pp-mo

Copy link
Owner

@lbdreyer lbdreyer Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now sort the list when it is created at load time:
SciTools@d8274ae#diff-3f092d0906b994c134f8f9d64c28652aR235

And so ugrid.node_coordinates now returns a list rather than a set

@lbdreyer lbdreyer merged commit 495f8e4 into lbdreyer:print_cube_ugrid Mar 23, 2020
@pp-mo pp-mo deleted the pp__print_cube_ugrid branch March 18, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbdreyer lbdreyer lbdreyer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pp-mo @lbdreyer