Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: layotto springboot #8

Merged
merged 6 commits into from
Mar 18, 2022
Merged

feat: layotto springboot #8

merged 6 commits into from
Mar 18, 2022

Conversation

ZLBer
Copy link
Contributor

@ZLBer ZLBer commented Dec 24, 2021

related issue: mosn/layotto#371

  • add layotto springboot
  • move RawSubscriber and EvenListener from examples to sdk, renamed DefaultSubscriber
  • add springboot examples

@seeflood
Copy link
Member

seeflood commented Dec 24, 2021 •
edited
Loading

Coool !
@zhenjunMa @MoonShining @RayneHwang @ujjboy Could u help review this PR?

Note : We should review the compatibility and make sure new PR won't affect existing users

@ZLBer
Copy link
Contributor Author

ZLBer commented Jan 5, 2022

@ujjboy thanks for your review, all resolved.

@seeflood seeflood assigned ujjboy and unassigned zhenjunMa Jan 5, 2022
@ZLBer
Copy link
Contributor Author

ZLBer commented Mar 2, 2022

@ujjboy all resolved

@ZLBer
Copy link
Contributor Author

ZLBer commented Mar 11, 2022

@ujjboy 去掉了Component和ComponentScan, 改成了ConditionalOnMissingBean和ConfigurationProperties

@seeflood seeflood mentioned this pull request Mar 16, 2022
Open
ujjboy
ujjboy approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seeflood
seeflood approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks 斌哥!

@seeflood seeflood merged commit 0abd671 into layotto:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenjunMa zhenjunMa zhenjunMa approved these changes

@seeflood seeflood seeflood approved these changes

@ujjboy ujjboy ujjboy approved these changes

@MoonShining MoonShining Awaiting requested review from MoonShining

Assignees

@ujjboy ujjboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZLBer @seeflood @ujjboy @zhenjunMa