feat: add new electedComponents token to sistent with new grey shades #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,7 @@ declare module '@mui/material/styles' { | |||
| default: string; | |||
| }; | |||
| tabs?: string; | |||
| elevatedComponents?: string; | |||
There was a problem hiding this comment.
@amitamrutiya we need to sure of this.. we don't want to add more and more tokens based on our needs otherwise we will be doing same mistake as it was in meshery of having so many colors. And we should use more genric names for such.
There was a problem hiding this comment.
This token #303030 we heavily used in Kanvas so I have to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits