Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to lava-dl to reflect api changes in lava 0.4.0 #88

Merged
merged 19 commits into from
Jul 25, 2022
Merged

Changes to lava-dl to reflect api changes in lava 0.4.0 #88

merged 19 commits into from
Jul 25, 2022

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Jul 22, 2022 •
edited
Loading

Issue Number: 87

Objective of pull request:
Fix lava-dl netx CPU execution broken changes.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Uses older lava api which is broken since lava 0.4.0 and beyond.

What is the new behavior?

  • All the unittests and tutorials work. Additional unittests added.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

bamsumit and others added 13 commits May 18, 2022 16:50
@bamsumit
Merge branch 'lava-nc:main' into main
4328af7
@bamsumit
Netx fixes for changes in lava api
a6dacc8 
Signed-off-by: bamsumit <[email protected]>
Update deps. versions
fb2ae13 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
@bamsumit
netx port initializer fork
015c57b 
Signed-off-by: bamsumit <[email protected]>
@mgkwill
Update pyproject.toml
d1e3aef
@bamsumit
Merge branch 'main' into update_versions
3c86caf
@bamsumit
Graded spikes fix. PilotNet LIF and SDNN runnning
b920dbb 
Signed-off-by: bamsumit <[email protected]>
Update to latest lava-nc main
a875342 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Merge branch 'update_versions' of github.com:lava-nc/lava-dl into upd…
1b57cba 
…ate_versions
@bamsumit
Fixed changes on slayer tests due to changes in lava api
8157ba9 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
SDNN NetX unittest added. Minor typo fixes
352ef70 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Linting fixes. CI pointing to latest main branch
0e9a2ab 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
CI pointing to latest lava
65c7cb4 
Signed-off-by: bamsumit <[email protected]>
@bamsumit bamsumit linked an issue Jul 22, 2022 that may be closed by this pull request
Broken changes with lava 0.4.0 #87
Closed
12 tasks
@bamsumit
Change PyProject dependency
5882199 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Change poetry lock
0fa6318 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Update CI job
3309ca9 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Update CI job
7302f2e 
Signed-off-by: bamsumit <[email protected]>
tim-shea
tim-shea approved these changes Jul 22, 2022
View reviewed changes
Copy link

@tim-shea tim-shea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pyproject.toml Show resolved Hide resolved
GaboFGuerra
GaboFGuerra approved these changes Jul 25, 2022
View reviewed changes
Copy link

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sumit, looks good. Left a few comments here and there, but nothing critical.

src/lava/lib/dl/netx/blocks/process.py Show resolved Hide resolved
src/lava/lib/dl/netx/blocks/process.py Show resolved Hide resolved
src/lava/lib/dl/netx/blocks/process.py Show resolved Hide resolved
src/lava/lib/dl/netx/hdf5.py Show resolved Hide resolved
src/lava/lib/dl/netx/hdf5.py Outdated Show resolved Hide resolved
src/lava/lib/dl/netx/hdf5.py Outdated Show resolved Hide resolved
src/lava/lib/dl/netx/hdf5.py Show resolved Hide resolved
tests/lava/lib/dl/netx/test_blocks.py Show resolved Hide resolved
tests/lava/lib/dl/netx/test_hdf5.py Show resolved Hide resolved
@bamsumit
Copy link
Contributor Author

Thanks Sumit, looks good. Left a few comments here and there, but nothing critical.

Thanks @GaboFGuerra, made changes to address your comments.

@bamsumit bamsumit merged commit 9ddcafd into lava-nc:main Jul 25, 2022
@bamsumit bamsumit deleted the netx_update branch July 25, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

@tim-shea tim-shea tim-shea approved these changes

@mgkwill mgkwill Awaiting requested review from mgkwill

@awintel awintel Awaiting requested review from awintel

@drager-intel drager-intel Awaiting requested review from drager-intel

@joyeshmishra joyeshmishra Awaiting requested review from joyeshmishra

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

@PhilippPlank PhilippPlank Awaiting requested review from PhilippPlank

@phstratmann phstratmann Awaiting requested review from phstratmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken changes with lava 0.4.0
4 participants
@bamsumit @tim-shea @GaboFGuerra @mgkwill