Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pilotnet integration tests #79

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Add pilotnet integration tests #79

merged 4 commits into from
Jun 3, 2022

Conversation

mgkwill
Copy link
Contributor

@mgkwill mgkwill commented May 31, 2022

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Add pilotnet integration tests
cfca149 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
@mgkwill mgkwill requested a review from bamsumit May 31, 2022 14:53
Marcus G K Williams added 3 commits June 2, 2022 14:52
Remove tag from RunConfig, import dataset.py
346b67a 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Cleanup, Fix Lint
b7fe9bc 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Remove unused import
25444cc 
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
@mgkwill mgkwill requested a review from bamsumit June 2, 2022 22:46
bamsumit
bamsumit approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. We will really know when we test it in hardware ;)

@mgkwill mgkwill merged commit 4bc9c6e into main Jun 3, 2022
@mgkwill mgkwill deleted the integration_test_pilotnet branch August 15, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamsumit bamsumit bamsumit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgkwill @bamsumit