Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline PilotNet SNN notebook with RefPorts #37

Merged
merged 10 commits into from
Mar 2, 2022
Merged

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Mar 2, 2022

Issue Number: 36

Objective of pull request:
Streamline PilotNet SNN notebook with RefPorts

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe): Notebook update

What is the current behavior?

  • Current notebook uses var.set/get api. So the network needs to be run at 1 timestep at a time.

What is the new behavior?

  • It now uses refports. Thus the whole network can be run at once.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bamsumit bamsumit merged commit e086551 into lava-nc:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants