Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilotnet link fix #31

Merged
merged 7 commits into from
Jan 19, 2022
Merged

Pilotnet link fix #31

merged 7 commits into from
Jan 19, 2022

Conversation

bamsumit
Copy link
Contributor

Issue Number: 22

Objective of pull request:
Fix broken link for Pilotnet

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • The link is broken.

What is the new behavior?

  • The link is fixed. Additional automated download script added.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit bamsumit self-assigned this Jan 13, 2022
@bamsumit bamsumit linked an issue Jan 13, 2022 that may be closed by this pull request
@ysingh7 ysingh7 self-requested a review January 18, 2022 20:57
Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the caveat that we should document that this only works on Linux with wget, unzip installed.

@bamsumit bamsumit merged commit f710fca into lava-nc:main Jan 19, 2022
@bamsumit bamsumit deleted the pilotnet_link_fix branch January 19, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PilotNet Tutorial]: Google Drive URL dataset is not valid
3 participants