-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/feature yolo #243
Merged
Merged
Dev/feature yolo #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamsumit
commented
Sep 29, 2023
bamsumit
commented
Sep 29, 2023
bamsumit
commented
Sep 29, 2023
src/lava/lib/dl/slayer/object_detection/boundingbox/__init__.py
Outdated
Show resolved
Hide resolved
Signed-off-by: bamsumit <[email protected]>
bamsumit
commented
Sep 29, 2023
Signed-off-by: y <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
bamsumit
commented
Sep 30, 2023
Closed
3 tasks
Signed-off-by: y <[email protected]>
Signed-off-by: y <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
bamsumit
force-pushed
the
dev/feature-yolo
branch
from
October 3, 2023 21:15
6dcb196
to
fd4d140
Compare
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: y <[email protected]>
Signed-off-by: y <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
bamsumit
requested review from
awintel,
tim-shea,
mathisrichter,
joyeshmishra,
mgkwill and
drager-intel
October 6, 2023 00:03
Dear Reviewers, Do not fret seeing a lot of files in the PR. Here are the main files to be reviewed in the order of priority. Please :
|
…s for model tiny_yolov3_str Signed-off-by: y <[email protected]>
…s for model tiny_yolov3_str Signed-off-by: y <[email protected]>
Signed-off-by: y <[email protected]>
Signed-off-by: bamsumit <[email protected]>
mgkwill
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few places to remove commented code and a couple of comment spelling errors, else LGTM.
src/lava/lib/dl/slayer/object_detection/models/Trained_tiny_yolov3_str/.gitattributes
Show resolved
Hide resolved
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: 242
Objective of pull request:
YOLO SDNN training and GPU inference pipeline
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
Does this introduce a breaking change?
Supplemental information