Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/feature yolo #243

Merged
merged 59 commits into from
Oct 17, 2023
Merged

Dev/feature yolo #243

merged 59 commits into from
Oct 17, 2023

Conversation

bamsumit
Copy link
Contributor

Issue Number: 242

Objective of pull request:
YOLO SDNN training and GPU inference pipeline

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Signed-off-by: bamsumit <[email protected]>
@bamsumit bamsumit linked an issue Sep 30, 2023 that may be closed by this pull request
3 tasks
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Copy link
Contributor Author

bamsumit commented Oct 6, 2023

Dear Reviewers,

Do not fret seeing a lot of files in the PR. Here are the main files to be reviewed in the order of priority. Please :

  • tutorials/lava/lib/dl/slayer/tiny_yolo_sdnn/README.md
  • tutorials/lava/lib/dl/slayer/tiny_yolo_sdnn/train_sdnn.py
  • tutorials/lava/lib/dl/slayer/tiny_yolo_sdnn/inference.ipynb
  • src/lava/lib/dl/slayer/object_detection/models/tiny_yolov3_str.py
  • src/lava/lib/dl/slayer/object_detection/models/yolo_kp.py
  • src/lava/lib/dl/slayer/object_detection/boundingbox/metrics.py
  • src/lava/lib/dl/slayer/object_detection/boundingbox/utils.py
  • src/lava/lib/dl/slayer/object_detection/dataset/bdd100k.py
  • src/lava/lib/dl/slayer/loss.py
  • and the rest :)

Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places to remove commented code and a couple of comment spelling errors, else LGTM.

@bamsumit bamsumit merged commit cfbcb25 into lava-nc:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YOLO SDNN training
3 participants