-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fix to check for complex synapse in create_dense #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rf neurons. Found a bug inside lava main code that does not allow greater than one neuron sizes for rf neurons that will prevent this current code from working. Will file bug report soon
Use latest lava-nc for CI tests, which includes the rf processes.
…x synapse in create_dense
Michaeljurado42
changed the title
Fix check for complex synapse in create_dense
Small fix to check for complex synapse in create_dense
Nov 18, 2022
I re-used an a previous fork for this PR. Is that okay, or should I create a new fork just for the specific change? |
10 tasks
bamsumit
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: 129
Objective of pull request: The check for a complex synapse fails in create_dense
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
In hdf5.py there is a line like this:
What is the new behavior?
Does this introduce a breaking change?
Supplemental information
This bug is the cause of an experimental change I made to a lava-dl fork which I forgot to remove.
Previously in a discussion post, @bamsumit discussed the possibility of having a complex_synapse key which would be used in this if-statement. However, adding this complex synapse key means that the current unit test ground truth data with .net files would have to be re-generated since they do not have this key.
This bug-fix removes the complex_synapse key and fixes the if statement that checks for complex synapses. More info given in the issue.