Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding __init__.py to lava-dl/lava #10

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Adding __init__.py to lava-dl/lava #10

merged 1 commit into from
Nov 18, 2021

Conversation

awintel
Copy link
Contributor

@awintel awintel commented Nov 18, 2021

lava-dl/lava had an empty init.py file which was causing PyCharm module inspection issues with multiple open projects.

@awintel awintel added the 1-bug Something isn't working label Nov 18, 2021
bamsumit
bamsumit approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It didn't break optimization import.

mgkwill
mgkwill approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally don't think we should be merging anything for IDE compatibility purposes.

But this change seems harmless and I actually have it locally.

@mgkwill mgkwill merged commit bc91ffb into lava-nc:main Nov 18, 2021
@awintel
Copy link
Contributor Author

awintel commented Nov 18, 2021

It's more of a consistency thing. If we define a name space a certain way in one repo we should do it the same way in all repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamsumit bamsumit bamsumit approved these changes

@mgkwill mgkwill mgkwill approved these changes

Assignees
No one assigned
Labels
1-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awintel @mgkwill @bamsumit