Skip to content

chore: upgrade Xunit.StaFact from 1.1.11 to 1.2.69#469

Merged
laurentiu021 merged 1 commit into
mainfrom
chore/stafact-upgrade
May 21, 2026
Merged

chore: upgrade Xunit.StaFact from 1.1.11 to 1.2.69#469
laurentiu021 merged 1 commit into
mainfrom
chore/stafact-upgrade

Conversation

@laurentiu021

@laurentiu021 laurentiu021 commented May 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Upgraded Xunit.StaFact from 1.1.11 to 1.2.69 (latest compatible with xUnit v2)
  • No API changes — [StaFact] attribute is identical across all 1.x versions
  • StaFact 3.x requires xUnit v3 (full test framework migration) — not feasible now

Context (issue #283)

The original Dependabot PR (#248) tried to bump to 3.x which requires xUnit v3. The correct path is to stay on 1.x line (latest 1.2.69) while on xUnit 2.9.3. Full xUnit v3 migration is a separate future effort.

Test plan

  • CI build passes
  • All 12 [StaFact] tests pass unchanged

Summary by CodeRabbit

  • Chores
    • Updated testing framework dependency to improve test infrastructure stability and compatibility.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d0bcbc1c-1bd6-4d2c-9e8e-432293265759

📥 Commits

Reviewing files that changed from the base of the PR and between 3b8867a and 4d4302b.

📒 Files selected for processing (1)
  • SysManager/SysManager.Tests/SysManager.Tests.csproj
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Analyze (csharp)
  • GitHub Check: Build & unit tests
🔇 Additional comments (1)
SysManager/SysManager.Tests/SysManager.Tests.csproj (1)

17-17: LGTM!


📝 Walkthrough

Walkthrough

A single NuGet package reference in the test project configuration is updated: Xunit.StaFact is bumped from version 1.1.11 to 1.2.69. No functional code changes are present.

Changes

Dependency Update

Layer / File(s) Summary
Xunit.StaFact package version bump
SysManager/SysManager.Tests/SysManager.Tests.csproj
Xunit.StaFact NuGet package reference updated from 1.1.11 to 1.2.69.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #283: Related — both address Xunit.StaFact package updates in the test project; this PR increments 1.1.11 to 1.2.69 as an intermediate step toward a potential migration.

Poem

🐰 A hop and a skip, dependencies align,
Xunit version bumps, the tests will be fine!
From one-one to sixty-nine, progress takes flight,
Our test harness freshened, everything bright! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: upgrading the Xunit.StaFact NuGet package from version 1.1.11 to 1.2.69, which is the sole modification in this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/stafact-upgrade

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurentiu021
laurentiu021 merged commit 1941432 into main May 21, 2026
5 checks passed
@laurentiu021
laurentiu021 deleted the chore/stafact-upgrade branch May 21, 2026 06:55
laurentiu021 added a commit that referenced this pull request May 22, 2026
Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant