chore: extract HumanSize to shared helper (QUAL-003)

[laurentiu021]

Summary

• Removed CleanupCategory.HumanSize() and consolidated all size formatting into FormatHelper.FormatSize()
• Updated FormatHelper.FormatSize to support TB and handle zero/negative values
• Updated all 4 model call sites + DeepCleanupViewModel + test files

Test plan

• CI build passes
• Unit tests pass (existing HumanSize tests now target FormatHelper.FormatSize)
• Size displays unchanged across UI (same formatting logic)

Summary by CodeRabbit

• New Features

  • Added terabyte (TB) support in human-readable size displays across the app.

• Bug Fixes

  • More consistent handling of zero, negative and extreme size values.
  • Size values now show one decimal place (e.g., "2.0 KB") for improved precision.

• Tests

  • Updated test suites to validate the new size-formatting behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba3f3f34-a655-4cab-a455-ea9782b1b50b

📥 Commits

Reviewing files that changed from the base of the PR and between 7db4aa9 and b7fd190.

📒 Files selected for processing (2)

• SysManager/SysManager.Tests/CleanupCategoryHumanSizeExtendedTests.cs
• SysManager/SysManager.Tests/ProcessManagerServiceTests.cs

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build & unit tests
• GitHub Check: Analyze (csharp)

🔇 Additional comments (2)

SysManager/SysManager.Tests/CleanupCategoryHumanSizeExtendedTests.cs (1)

86-86: LGTM!

SysManager/SysManager.Tests/ProcessManagerServiceTests.cs (1)

120-120: LGTM!

---

📝 Walkthrough

Walkthrough

This PR centralizes human-readable byte formatting by enhancing FormatHelper.FormatSize (B→TB, edge cases), removing CleanupCategory.HumanSize, and migrating all model/viewmodel display properties and tests to use FormatHelper.FormatSize.

Changes

Size formatting consolidation

Layer / File(s)	Summary
FormatHelper.FormatSize core refactor SysManager/SysManager/Helpers/FormatHelper.cs	Updates FormatSize(long bytes) to return "0 B" for non-positive values, keep <1KB as "X B", and scale to KB/MB/GB/TB with F1 formatting for unit values.
CleanupCategory model migration SysManager/SysManager/Models/CleanupCategory.cs	Adds using SysManager.Helpers;, removes CleanupCategory.HumanSize(long), and updates SizeDisplay, LargeFileEntry.SizeDisplay, and CleanupResult.Summary to call FormatHelper.FormatSize.
Related models migration SysManager/SysManager/Models/DiskUsageEntry.cs, SysManager/SysManager/Models/InstalledApp.cs, SysManager/SysManager/Models/ProcessEntry.cs, SysManager/SysManager/Models/TuneUpResult.cs	Updates computed display properties (SizeDisplay, MemoryDisplay, FreedDisplay) to use FormatHelper.FormatSize and adds the necessary using imports.
DeepCleanupViewModel display updates SysManager/SysManager/ViewModels/DeepCleanupViewModel.cs	Switches TotalSelectedDisplay, LargeBytesScannedDisplay, final ScanSummary, and completion log formatting to FormatHelper.FormatSize.
Test suite updates SysManager/SysManager.IntegrationTests/CleanupCategoryTests.cs, SysManager/SysManager.Tests/CleanupCategoryHumanSizeBulkTests.cs, SysManager/SysManager.Tests/CleanupCategoryHumanSizeExtendedTests.cs, SysManager/SysManager.Tests/ProcessManagerServiceTests.cs	Replaces calls to CleanupCategory.HumanSize with FormatHelper.FormatSize, updates expected strings (adds .0 precision at KB/MB/GB/TB thresholds), and adds using SysManager.Helpers where needed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• laurentiu021/SystemManager#254: Touches the same size-display codepaths and previously standardized call sites to a shared formatter.
• laurentiu021/SystemManager#434: Also refactors/validates FormatHelper.FormatSize boundary behavior and tests.
• laurentiu021/SystemManager#420: Introduces/refactors the shared FormatHelper.FormatSize helper and migrates callers to it.

Poem

🐰 Soft paws on keys, I hop and plot,
Bytes shrink to labels, neat and taut.
TB joins KB in tidy rows,
One helper sings where chaos grows.
Hooray — formatted and well-sought!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: extracting the HumanSize method into a shared FormatHelper, which is the central refactoring across all modified files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/extract-human-size

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}