docs: assign version headers to CHANGELOG entries for v0.48.36–v0.48.38#452
Merged
Conversation
📝 WalkthroughWalkthroughCHANGELOG.md is reorganized to introduce versioned release headers for versions 0.48.38 and 0.48.37 under "Unreleased", each with their fixed items. Previously-unreleased entries are consolidated under version headers. A new "Added" entry documents ServicesViewModelTests coverage for ChangesRelease Notes Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 9-29: Add link reference definitions for the new release headers
so the bracketed version labels resolve to GitHub Release pages: add definitions
for [0.48.38], [0.48.37], and [0.48.36] matching the repository's existing
release-link pattern (e.g. the same format used by other entries in the file,
typically pointing to the releases/tag/vX.Y.Z URL) and place them with the other
link definitions at the bottom of CHANGELOG.md; ensure each label maps to the
correct tag (v0.48.38, v0.48.37, v0.48.36).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 01274119-0d47-41fe-84df-8b3941c0f768
📒 Files selected for processing (1)
CHANGELOG.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build & unit tests
- GitHub Check: Analyze (csharp)
Comment on lines
+9
to
+29
| ## [0.48.38] - 2026-05-20 | ||
|
|
||
| ### Fixed | ||
| - **LogService** — path sanitization regex now dynamically derives the user | ||
| profile directory from `Environment.GetFolderPath` instead of assuming a | ||
| hardcoded `<drive>:\Users\` pattern; falls back to the generic regex if the | ||
| environment variable is unavailable. | ||
| - **MarkdownTextBlock** — cached `FontFamily("Consolas")` as a static field to | ||
| eliminate per-render allocation in code span formatting. | ||
|
|
||
| ## [0.48.37] - 2026-05-19 | ||
|
|
||
| ### Fixed | ||
| - **DiskHealthReport** — fixed potential integer overflow in `HealthPercent` | ||
| calculation when `ReadErrors` or `WriteErrors` exceed `int.MaxValue`; arithmetic | ||
| now uses `long` before clamping to the 0–20 deduction cap. | ||
| - **SpeedTestService** — documented pinned Ookla CLI version (`1.2.0`) with | ||
| maintenance comment explaining update procedure and Authenticode verification. | ||
|
|
||
| ## [0.48.36] - 2026-05-19 | ||
|
|
There was a problem hiding this comment.
Add missing release link definitions for the new version headers.
The new headers use reference-style links ([0.48.38], [0.48.37], [0.48.36]), but this file currently has no corresponding link definitions, so they are not actually mapped to GitHub Releases as intended by the PR objective.
Proposed fix
+ [Unreleased]: https://github.com/laurentiu021/SystemManager/compare/v0.48.38...HEAD
+ [0.48.38]: https://github.com/laurentiu021/SystemManager/releases/tag/v0.48.38
+ [0.48.37]: https://github.com/laurentiu021/SystemManager/releases/tag/v0.48.37
+ [0.48.36]: https://github.com/laurentiu021/SystemManager/releases/tag/v0.48.36📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ## [0.48.38] - 2026-05-20 | |
| ### Fixed | |
| - **LogService** — path sanitization regex now dynamically derives the user | |
| profile directory from `Environment.GetFolderPath` instead of assuming a | |
| hardcoded `<drive>:\Users\` pattern; falls back to the generic regex if the | |
| environment variable is unavailable. | |
| - **MarkdownTextBlock** — cached `FontFamily("Consolas")` as a static field to | |
| eliminate per-render allocation in code span formatting. | |
| ## [0.48.37] - 2026-05-19 | |
| ### Fixed | |
| - **DiskHealthReport** — fixed potential integer overflow in `HealthPercent` | |
| calculation when `ReadErrors` or `WriteErrors` exceed `int.MaxValue`; arithmetic | |
| now uses `long` before clamping to the 0–20 deduction cap. | |
| - **SpeedTestService** — documented pinned Ookla CLI version (`1.2.0`) with | |
| maintenance comment explaining update procedure and Authenticode verification. | |
| ## [0.48.36] - 2026-05-19 | |
| ## [0.48.38] - 2026-05-20 | |
| ### Fixed | |
| - **LogService** — path sanitization regex now dynamically derives the user | |
| profile directory from `Environment.GetFolderPath` instead of assuming a | |
| hardcoded `<drive>:\Users\` pattern; falls back to the generic regex if the | |
| environment variable is unavailable. | |
| - **MarkdownTextBlock** — cached `FontFamily("Consolas")` as a static field to | |
| eliminate per-render allocation in code span formatting. | |
| ## [0.48.37] - 2026-05-19 | |
| ### Fixed | |
| - **DiskHealthReport** — fixed potential integer overflow in `HealthPercent` | |
| calculation when `ReadErrors` or `WriteErrors` exceed `int.MaxValue`; arithmetic | |
| now uses `long` before clamping to the 0–20 deduction cap. | |
| - **SpeedTestService** — documented pinned Ookla CLI version (`1.2.0`) with | |
| maintenance comment explaining update procedure and Authenticode verification. | |
| ## [0.48.36] - 2026-05-19 | |
| [Unreleased]: https://github.com/laurentiu021/SystemManager/compare/v0.48.38...HEAD | |
| [0.48.38]: https://github.com/laurentiu021/SystemManager/releases/tag/v0.48.38 | |
| [0.48.37]: https://github.com/laurentiu021/SystemManager/releases/tag/v0.48.37 | |
| [0.48.36]: https://github.com/laurentiu021/SystemManager/releases/tag/v0.48.36 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 9 - 29, Add link reference definitions for the new
release headers so the bracketed version labels resolve to GitHub Release pages:
add definitions for [0.48.38], [0.48.37], and [0.48.36] matching the
repository's existing release-link pattern (e.g. the same format used by other
entries in the file, typically pointing to the releases/tag/vX.Y.Z URL) and
place them with the other link definitions at the bottom of CHANGELOG.md; ensure
each label maps to the correct tag (v0.48.38, v0.48.37, v0.48.36).
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…hes (#452) ## What does this PR do? Fixes all issues found during the full code audit: ### Bug fixes (crash-level) - **CleanupViewModel** — SFC and DISM encoding crash (same as #443, missed callers) - **WingetService** — regex too restrictive for package IDs with spaces (same as #444, missed caller) ### CodeQL fixes - Replaced bare `catch { }` with specific exception types in: - DiskHealthService (ManagementException, UnauthorizedAccessException) - FixedDriveService (ManagementException) - MemoryTestService (EventLogException, UnauthorizedAccessException, InvalidOperationException, Win32Exception) - SystemInfoService (ManagementException) - AdminHelper (InvalidOperationException, Win32Exception) ### Documentation - SECURITY.md: version table updated from 0.5.x to 0.28.x - ARCHITECTURE.md: removed stale tab counts ## Type of change - [x] Bug fix (`fix:`) - [x] Code quality / CodeQL (`fix:`) - [x] Documentation (`docs:`) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…38 (#452) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit
Bug Fixes
Documentation