chore: rename OutputKindToBrushConverter.cs to ValueConverters.cs (QUAL-005)#450
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughFile header comment in ChangesHeader Comment Correction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…#450) ## What does this PR do? Fixes two user-reported crashes: 1. **#443 — Encoding 437 crash during chkdsk scan**: On systems where OEM code page 437 is not registered, `Encoding.GetEncoding()` throws `NotSupportedException`. Now wrapped in try-catch with UTF-8 fallback. 2. **#444 — Invalid packageId during uninstall**: Winget package IDs can contain spaces (e.g. `Riot Games.League of Legends`). The validation regex now allows `\s` characters. ## Files changed - `SystemHealthViewModel.cs` — encoding fallback - `UninstallerService.cs` — regex pattern update - `CHANGELOG.md` — v0.28.27 entry Closes #443 Closes #444 ## Type of change - [x] Bug fix (`fix:`) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…AL-005) (#450) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file contained 5 unrelated converters (OutputKindToBrush, FlexibleBoolToVisibility, BoolToElevationBadgeBrush, HexToBrush, ProcessStatusToBrush) but was named after only the first one. Renamed to ValueConverters.cs to accurately reflect its contents.
Summary by CodeRabbit
Note: This release contains only internal documentation updates with no impact on end-user functionality.