chore: seal non-inheritable model and converter classes (MODERN-005)#446
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between c7043465d595528d545297b60bf34bd9f883f3fe and a6674cc. 📒 Files selected for processing (20)
✅ Files skipped from review due to trivial changes (3)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (17)
📝 WalkthroughWalkthroughThis PR marks 25 public classes as sealed (five WPF converters and twenty ObservableObject model classes). No logic, members, or behavior changed. ChangesClass Inheritance Prevention
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
laurentiu021
force-pushed
the
chore/seal-classes
branch
from
May 20, 2026 06:22
c704346 to
a6674cc
Compare
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…446) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sealed modifier to 24 classes that are not designed for inheritance:
Converters (5): OutputKindToBrushConverter, FlexibleBoolToVisibilityConverter, BoolToElevationBadgeBrushConverter, HexToBrushConverter, ProcessStatusToBrushConverter
Models (19): AppInstallEntry, AppPackage, BatteryInfo, BlockedApp, BrokenShortcut, CleanupCategory, DiskHealthReport, DiskUsageEntry, DuplicateFileGroup, DuplicateFileEntry, FriendlyEventEntry, HealthDiagnostic, InstalledApp, PerformanceProfile, PingTarget, ProcessEntry, ServiceEntry, StartupEntry, TracerouteHop, WindowsFeature
Sealing prevents unintended inheritance and enables JIT devirtualization optimizations.
Build: 0 errors (main + tests).
Summary by CodeRabbit