chore: inclusive language (blocklist, allowlist, list-detail)#395
Merged
Conversation
- CHANGELOG.md: blacklist -> blocklist, whitelist -> allowlist - LogsView.xaml: Master-detail -> List-detail (comment) - UninstallerService.cs: whitelist -> allowlist (comment) - WingetService.cs: whitelist -> allowlist (comment)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (4)
📝 WalkthroughWalkthroughFour comment and documentation updates modernize terminology: changelog and validation comments switch from whitelist/blacklist to allowlist/blocklist language, and a UI layout label changes from master-detail to list-detail. No functional logic is altered. ChangesTerminology and Comment Updates
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…w close (#417) ## What changed ### Problem ViewModels implement IDisposable (via ViewModelBase) and several override Dispose(bool) to clean up resources, but nobody ever called Dispose(). When the window closed, timers kept running, event handlers leaked, and CancellationTokenSources were never disposed. ### Fix - **NetworkViewModel**: added Dispose override — stops pinger, unsubscribes events, disposes CTS - **NetworkSharedState**: added IDisposable — stops pinger, trace monitor, flush timer - **MainWindowViewModel**: added IDisposable — disposes ALL child ViewModels + NetworkSharedState - **MainWindow.xaml.cs**: added OnClosed — calls Dispose on the ViewModel ### Dispose chain Window.OnClosed → MainWindowViewModel.Dispose() → each ChildVM.Dispose() + NetworkSharedState.Dispose() ### Files changed - MainWindow.xaml.cs - ViewModels/MainWindowViewModel.cs - ViewModels/NetworkViewModel.cs - ViewModels/NetworkSharedState.cs Closes #395, closes #410 Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
Adds CHANGELOG entries for all 9 releases from the QA bug fix session: - **v0.28.16** — Dispose lifecycle (#395, #410) - **v0.28.17** — CTS disposal + bare catch (#396, #413) - **v0.28.18** — Input validation + null checks (#397, #398) - **v0.28.19** — JSON error handling (#400) - **v0.28.20** — Drive scanning + cache eviction + ConfigureAwait (#401, #402, #403) - **v0.28.21** — Audit logging + error messages (#405, #407) - **v0.28.22** — SHA256 verification (#408, #409) - **v0.28.23** — Service timeout + snapshot persist + traceroute DNS (#414, #415, #416) - **v0.28.24** — Accessibility (#411) 18 bugs fixed in total. Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
- CHANGELOG.md: blacklist -> blocklist, whitelist -> allowlist - LogsView.xaml: Master-detail -> List-detail (comment) - UninstallerService.cs: whitelist -> allowlist (comment) - WingetService.cs: whitelist -> allowlist (comment) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace non-inclusive terminology across the codebase:
chore: prefix — no release triggered.
Summary by CodeRabbit