feat!: migrate to .NET 9 + fix DI cross-talk + minor fixes#291
Conversation
BREAKING CHANGE: requires .NET 9 runtime (net9.0-windows TFM). - Migrate all 4 projects from net8.0-windows to net9.0-windows - Update CI workflows (ci.yml, codeql.yml, release.yml) to .NET 9 SDK - Bump Microsoft.Extensions.DependencyInjection 8.0.1 → 9.0.4 - Fix DI regression: PowerShellRunner changed from Singleton to Transient (prevents LineReceived event cross-talk between tabs) - Fix Uninstaller empty row (filter names < 2 chars) - Fix Process Manager column resize (explicit CanUserResizeColumns) - Fix Windows Features admin badge (show warning when not elevated) - Fix SYSLIB0057 warning (pragma suppress CreateFromSignedFile) - Update README: .NET 9 in tech stack and build prerequisites - Update ARCHITECTURE.md: .NET 9 reference - Update CHANGELOG with v0.47.0 entry Closes #257
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
📜 Recent review details🔇 Additional comments (15)
📝 WalkthroughWalkthroughThis PR completes the migration from .NET 8 to .NET 9 across all SysManager projects and CI/CD workflows, upgrades the DependencyInjection NuGet package, corrects the PowerShellRunner service lifetime to transient, and includes four targeted bug fixes for the uninstaller, process manager, Windows features UI, and Authenticode verification. Changes.NET 9 Migration and Bug Fixes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Adds CHANGELOG.md entries for the three releases from this session: - **v0.21.7** — UI freeze fixes (async offloading for Cleanup, Speed Test, Drivers) - **v0.21.8** — chkdsk admin privilege check - **v0.21.9** — SFC/DISM elevation consent dialog Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
BREAKING CHANGE: requires .NET 9 runtime (net9.0-windows TFM). - Migrate all 4 projects from net8.0-windows to net9.0-windows - Update CI workflows (ci.yml, codeql.yml, release.yml) to .NET 9 SDK - Bump Microsoft.Extensions.DependencyInjection 8.0.1 → 9.0.4 - Fix DI regression: PowerShellRunner changed from Singleton to Transient (prevents LineReceived event cross-talk between tabs) - Fix Uninstaller empty row (filter names < 2 chars) - Fix Process Manager column resize (explicit CanUserResizeColumns) - Fix Windows Features admin badge (show warning when not elevated) - Fix SYSLIB0057 warning (pragma suppress CreateFromSignedFile) - Update README: .NET 9 in tech stack and build prerequisites - Update ARCHITECTURE.md: .NET 9 reference - Update CHANGELOG with v0.47.0 entry Closes #257 Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
Summary
Migrates the entire solution from .NET 8 to .NET 9. Fixes DI regression and several minor UI issues found during testing.
Changes
BREAKING: requires .NET 9 runtime
Closes #257
Summary by CodeRabbit
Bug Fixes
Chores