docs: update README, ARCHITECTURE, SECURITY for v0.44-v0.46#290
Conversation
- README: update tab count (25 implemented, 11 WIP), add Windows Features description - ARCHITECTURE: update VM table (WindowsFeatures, AppAlerts, ShortcutCleaner, AppBlocker now real), add ServiceRegistration.cs to layout, add DI section, add WindowsFeaturesService + UninstallerService descriptions - SECURITY: update supported versions (0.44.x-0.46.x supported, <0.43 unsupported)
📝 WalkthroughWalkthroughThis PR updates project documentation to reflect the current system architecture, feature development progress, and version support policy. ARCHITECTURE.md is expanded with solution structure details, service descriptions, and a new Dependency Injection section. README.md feature counts and SECURITY.md version matrix are refreshed. ChangesDocumentation Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ARCHITECTURE.md`:
- Around line 121-124: Update the WindowsFeaturesService description to
explicitly list the PowerShell cmdlet used for disabling features: mention
Disable-WindowsOptionalFeature alongside Get-WindowsOptionalFeature and
Enable-WindowsOptionalFeature in the `WindowsFeaturesService` bullet so the
service reads that it lists, enables and disables Windows optional features via
Get-WindowsOptionalFeature / Enable-WindowsOptionalFeature /
Disable-WindowsOptionalFeature.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0634e16d-b627-45f6-8dac-b0464ceea18a
📒 Files selected for processing (3)
ARCHITECTURE.mdREADME.mdSECURITY.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (csharp)
- GitHub Check: Build & unit tests
🔇 Additional comments (3)
SECURITY.md (1)
15-19: LGTM!ARCHITECTURE.md (1)
24-24: LGTM!Also applies to: 41-43, 46-46, 72-75, 133-140
README.md (1)
40-41: LGTM!
| - `WindowsFeaturesService` — list, enable, disable Windows optional features | ||
| via `Get-WindowsOptionalFeature` / `Enable-WindowsOptionalFeature` PowerShell. | ||
| - `UninstallerService` — winget-based uninstall + registry UninstallString | ||
| fallback for local apps not in winget. |
There was a problem hiding this comment.
Document the disable command explicitly.
This line says WindowsFeaturesService can disable features, but only lists Get-WindowsOptionalFeature and Enable-WindowsOptionalFeature. Please include Disable-WindowsOptionalFeature to avoid ambiguity.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ARCHITECTURE.md` around lines 121 - 124, Update the WindowsFeaturesService
description to explicitly list the PowerShell cmdlet used for disabling
features: mention Disable-WindowsOptionalFeature alongside
Get-WindowsOptionalFeature and Enable-WindowsOptionalFeature in the
`WindowsFeaturesService` bullet so the service reads that it lists, enables and
disables Windows optional features via Get-WindowsOptionalFeature /
Enable-WindowsOptionalFeature / Disable-WindowsOptionalFeature.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- README: update tab count (25 implemented, 11 WIP), add Windows Features description - ARCHITECTURE: update VM table (WindowsFeatures, AppAlerts, ShortcutCleaner, AppBlocker now real), add ServiceRegistration.cs to layout, add DI section, add WindowsFeaturesService + UninstallerService descriptions - SECURITY: update supported versions (0.44.x-0.46.x supported, <0.43 unsupported) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
Updates all documentation to reflect features delivered in v0.44.0-v0.46.0.
Summary by CodeRabbit