-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for default limit #1
Comments
ran into this, was there a reason not to implement as a starlette Line 114 in 4c4141a
|
Hi Reuben,
Indeed I had tried at the start, to replicate the functionally of `flask-limiter`, but I couldn't get it to work the way I wanted. I forget the details, but I think it was something along the lines of Starlette's API not allowing the pattern I had in mind. It has probably changed by now, so feel free to implement, I'd be super grateful for a PR!
…On 1 July 2020 21:16:23 BST, Reuben Thomas-Davis ***@***.***> wrote:
ran into this, was there a reason not to implement as a starlette
`BaseHTTPMiddleware`? it seems like you started doing that here
https://github.com/laurentS/slowapi/blob/4c4141a7dbecf03cd03e0a4529bcf9ba42de687b/slowapi/extension.py#L114
happy to have a crack at implementing that and the exempt decorator
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1 (comment)
|
Closing this as default limit is now available via the middleware, thank @Rested ! |
ME-ON1
added a commit
to ME-ON1/slowapi
that referenced
this issue
Jun 16, 2022
fix: rm redis package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There should be a way to declare a default set of limits that apply to all endpoints without explicitly marking each endpoint with the decorator.
The text was updated successfully, but these errors were encountered: