Skip to content

Desktop: Accessibility: Fix input fields not associated with labels #11700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2025
Merged

Desktop: Accessibility: Fix input fields not associated with labels #11700

merged 4 commits into from
Jan 27, 2025

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Jan 21, 2025

Summary

Add labels to note properties input fields

Accessibility

Related to technique H44 that is here satisfying the WCAG 1.3.1

Goal
Information about content structure is available to more people.

Testing

  1. Open Note properties
  2. Press edit button on any input field
  3. Now label should be associated with the input field and the screen reader should name the input

@pedr pedr added desktop All desktop platforms accessibility Related to accessibility labels Jan 21, 2025
@pedr pedr mentioned this pull request Jan 21, 2025
Open
@pedr
Copy link
Collaborator Author

pedr commented Jan 22, 2025 •
edited
Loading

  • Use useId hook instead (if possible)

@personalizedrefrigerator personalizedrefrigerator merged commit 68f4b8e into laurent22:dev Jan 27, 2025
7 checks passed
@pedr pedr deleted the note-properties-labels branch February 1, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@personalizedrefrigerator personalizedrefrigerator personalizedrefrigerator approved these changes

Assignees
No one assigned
Labels
accessibility Related to accessibility desktop All desktop platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedr @personalizedrefrigerator