Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus Icon disappeared #11276

Closed
ErwinH1 opened this issue Oct 27, 2024 · 4 comments · Fixed by #11323
Closed

Plus Icon disappeared #11276

ErwinH1 opened this issue Oct 27, 2024 · 4 comments · Fixed by #11323
Labels
android bug It's a bug high High priority issues

Comments

@ErwinH1
Copy link

ErwinH1 commented Oct 27, 2024

Operating system

Android

Joplin version

3.0.8

Desktop version info

No response

Current behaviour

GrapheneOS, based on Android 15
Joplin 3.0.8

Note: I installed Joplin from Aurora-store, which caused no problem for the app to work fine for more than a year.

Recently the Plus Icon (to create new notes) has disappeared. I do not know exactly how long ago the icon was still there, but it must have been not more than two weeks ago.

I tried switching to another notebook, then closing the app and restarting it, but it didn't help.

Expected behaviour

To display the icon

Logs

No response

@ErwinH1 ErwinH1 added the bug It's a bug label Oct 27, 2024
@Garbulix
Copy link

I have the same issue for version 3.1.6 installed from Droid-ify (so from F-Droid repo). Also GrapheneOS based on Android 15. Exploit protection compatibility mode is enabled. Wiping app storage nor reinstalling the app doesn't solve the issue.

@Garbulix
Copy link

Because we have other Joplin versions, I guess this problem is related with Android and its upgrade to 15.

It looks like this plus button is somehow hidden "below" the screen as when I switch from navigating using 3 buttons (which I used until now) to navigating using gestures, I found its small fragment. It's hard to touch it but its possible and then submenu appears as expected. When I close this plus submenu, the button comes back to its initial place (still shows incorrectly).

ResizedImage_2024-10-30_14-41-59_1380.png

ResizedImage_2024-10-30_14-41-15_6049.png

@tomasz1986
Copy link

@Garbulix
Copy link

Garbulix commented Nov 1, 2024

What's also interesting to me is that the icon to edit content of the note when you are in note view is displayed correctly.

Screenshot_20241101-195056.png

@personalizedrefrigerator personalizedrefrigerator added high High priority issues android labels Nov 5, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Nov 6, 2024
…n certain Android devices

This commit adjusts an accessibility bug workaround from
(laurent22#10123), which was first present in Android v3.0.1.

**Background**:
React Native Paper's FAB.Group by default renders an invisible <View> that covers most/all
of Joplin's UI when the FAB.Group is collapsed. This breaks TalkBack on Android's "tap to
navigate" feature, which significantly impacts users that rely on TalkBack's ability to use
the app.
Starting from Joplin v3.0.1, the <View> added by React Native is made smaller by Joplin by
adding margins above and to the left. These margins are determined by the screen size and an
offset. This solution isn't perfect because it means that a small portion of the screen still
blocks TalkBack's tap-to-navigate. As reported in laurent22#11276, this workaround also pushed the new
note/new to-do buttons offscren.

**The change**
This commit changes how the FAB.Group's invisible <View> is resized. Previously it was done
with margins. Now, it's done with the top/left absolute positioning properties.

**Note**
If [this upstream pull request](callstack/react-native-paper#4514) is
merged, it should be possible to remove the workaround entirely.

**Remaining steps**
More testing is required before a pull request can be opened. For now, (in part because this is
not a regression from v3.0), I plan to target release-3.2, rather than
release-3.1, to avoid introducing additional regressions in the 3.1 version of the app.

Should fix laurent22#11276, laurent22#11315.
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Nov 7, 2024
…n certain Android devices

This commit adjusts an accessibility bug workaround from
(laurent22#10123), which was first present in Android v3.0.1.

**Background**:
React Native Paper's FAB.Group by default renders an invisible <View> that covers most/all
of Joplin's UI when the FAB.Group is collapsed. This breaks TalkBack on Android's "tap to
navigate" feature, which significantly impacts users that rely on TalkBack's ability to use
the app.
Starting from Joplin v3.0.1, the <View> added by React Native is made smaller by Joplin by
adding margins above and to the left. These margins are determined by the screen size and an
offset. This solution isn't perfect because it means that a small portion of the screen still
blocks TalkBack's tap-to-navigate. As reported in laurent22#11276, this workaround also pushed the new
note/new to-do buttons offscren.

**The change**
This commit changes how the FAB.Group's invisible <View> is resized. Previously it was done
with margins. Now, it's done with the top/left absolute positioning properties.

**Note**
If [this upstream pull request](callstack/react-native-paper#4514) is
merged, it should be possible to remove the workaround entirely.

**Remaining steps**
More testing is required before a pull request can be opened. For now, (in part because this is
not a regression from v3.0), I plan to target release-3.2, rather than
release-3.1, to avoid introducing additional regressions in the 3.1 version of the app.

Should fix laurent22#11276, laurent22#11315.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug It's a bug high High priority issues
Projects
None yet
4 participants