Support Python 3.11, drop older Pythons entirely #59

colindean · 2022-12-16T04:11:28Z

This includes #58 and then drops Pythons older than 3.7 since they're all EOL. It also updates some GHA action versions.

colindean · 2022-12-16T04:12:03Z

tox.ini

-    py{27,34,35,36,37,38,39,310}-wrapt{1.10,1.11,1.12,1.13}
-    pypy, pypy3
+    py{37,38,39,310}-wrapt{1.10,1.11,1.12,1.13,1.14}
+    py{311}-wrapt{1.14}


1.14 is needed to get Python 3.11 working GrahamDumpleton/wrapt#196

colindean · 2022-12-16T04:14:08Z

https://app.travis-ci.com/github/tantale/deprecated/jobs/591380170#L212-L213 indicates that the 3.7 build needs an updated version of the import_metadata library. IIRC this necessity goes away in 3.8 or newer…

This may need to go into install deps…

Also fix error in pypy3 selection

tox-dev/tox-travis#160

colindean · 2022-12-16T06:19:42Z

At this point, all Travis x86 jobs are completed…

AppVeyor can't seem to find a python.exe in the path specified for Python 3.9 or later, so let's explicitly set the image version just in case somehow an older image is being used— AppVeyor doesn't say which image is in use on a build's page…?

I have no idea what I'm doing but I glanced at the docs in [this][1] and [this][2] and feel like I'm on the right track to silencing the warnings. [1]: https://packit.dev/posts/copr-srpms/#deployment-phases [2]: https://packit.dev/docs/configuration/#srpm_build_deps

colindean · 2022-12-19T14:50:46Z

Travis build failures are transient, it seems. Those failing jobs have succeeded in the past with no relevant changes in the meantime.

hugovk

Looks good, especially the wrapt >= 1.14.0 requirement for Python 3.11+, without which is causing problems for users of other libraries which depend on Deprecated:

PyGithub/PyGithub#2377

Some minor suggestions added.

.travis.yml

 install:
-  - pip install coveralls tox-travis
+  # TODO: Remove tox limitation when https://github.com/tox-dev/tox-travis/pull/160


CHANGELOG.rst

+Other
+-----
+
+- Add support for Python 3.11.


hugovk · 2023-01-15T11:17:41Z

setup.py

-            'configparser < 5             ; python_version < "3"',
-            'sphinxcontrib-websupport < 2 ; python_version < "3"',
-            'zipp < 2                     ; python_version < "3"',
+            'importlib-metadata'


Is this library used anywhere?

Yes. It's still required for Python 3.7. It can be removed when 3.7 support goes away, which I'd recommend doing when 3.7 is EOL later this year.

I didn't actually see it used in the code?

Anyway, one suggestion is to use the stdlib version for 3.8+:

'importlib-metadata; python_version < "3.8"',

try: # Python 3.8+ import importlib.metadata as importlib_metadata except ImportError: # Python 3.7 import importlib_metadata # type: ignore

And then it can be removed when 3.7 is EOL in June: https://devguide.python.org/versions/

I failed to document why I added it in 1827126 but I did note that it is needed for dev only. I think maybe wrapt needed it?

$ rg importlib setup.py 187: 'importlib-metadata' $ rg metadata setup.py 187: 'importlib-metadata'

What's the danger of leaving it now and coming back to removing it? It's a dev dep so it shouldn't affect the public dependencies list.

Ya know, I'll bet I had it in there to consolidate the lines removed below, assuming that importlib-metadata was actually used somewhere…

hugovk · 2023-01-15T11:19:59Z

tox.ini

+    py{37,38,39,310}-wrapt{1.10,1.11,1.12,1.13,1.14}
+    py{311,312}-wrapt{1.14}


Do we need to test five versions of wrapt? 1.10 is from 2017, pretty old by now.

If we're adding two, shall we remove two?

Support table:

Wrapt version° Pythons supported

1.10.x 2.6, 2.7, 3.3, 3.4, 3.5, 3.6

1.11.x 2.6, 2.7, 3.3, 3.4, 3.5, 3.6, 3.7

1.12.x 2.7, 3.4, 3.5, 3.6, 3.7, 3.8

1.13.x 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10

1.14.x 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11

1.15.x rc 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11

It looks very safe to drop 1.10 because none of its supported versions would be supported in the next Deprecated release if this PR is merged. I'd call it safe enough to drop 1.11-1.12 and probably even 1.13, tbh.

°: latest in series

I'd say let's keep the wrapt dep and testing at 1.10+ for this PR and if I have time this week (long shot), I can do the work to eliminate 1.10-1.13 to settle on 1.14+.

.travis.yml

CHANGELOG.rst

colindean · 2023-01-16T00:58:29Z

setup.py

-            'configparser < 5             ; python_version < "3"',
-            'sphinxcontrib-websupport < 2 ; python_version < "3"',
-            'zipp < 2                     ; python_version < "3"',
+            'importlib-metadata'


Yes. It's still required for Python 3.7. It can be removed when 3.7 support goes away, which I'd recommend doing when 3.7 is EOL later this year.

colindean · 2023-01-16T01:07:29Z

tox.ini

+    py{37,38,39,310}-wrapt{1.10,1.11,1.12,1.13,1.14}
+    py{311,312}-wrapt{1.14}


Support table:

Wrapt version° Pythons supported

1.10.x 2.6, 2.7, 3.3, 3.4, 3.5, 3.6

1.11.x 2.6, 2.7, 3.3, 3.4, 3.5, 3.6, 3.7

1.12.x 2.7, 3.4, 3.5, 3.6, 3.7, 3.8

1.13.x 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10

1.14.x 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11

1.15.x rc 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11

It looks very safe to drop 1.10 because none of its supported versions would be supported in the next Deprecated release if this PR is merged. I'd call it safe enough to drop 1.11-1.12 and probably even 1.13, tbh.

°: latest in series

colindean · 2023-01-16T01:09:36Z

tox.ini

+    py{37,38,39,310}-wrapt{1.10,1.11,1.12,1.13,1.14}
+    py{311,312}-wrapt{1.14}


I'd say let's keep the wrapt dep and testing at 1.10+ for this PR and if I have time this week (long shot), I can do the work to eliminate 1.10-1.13 to settle on 1.14+.

See tox-dev/tox-travis#160

.travis.yml

Co-authored-by: Hugo van Kemenade <[email protected]>

hugovk

Looks good, thank you!

colindean · 2023-01-16T19:17:41Z

@tantale I'd love your feedback and to see this merged and released.

colindean · 2023-02-22T01:57:50Z

@tantale What feedback do you have?

sbor23 · 2023-03-16T07:59:29Z

Any news? I just did the same work without seeing this.

laurent-laporte-pro · 2023-03-20T08:23:17Z

Hello,

Sorry for the (very) late answer: I don’t have much time to work on this project.

Anyway, you made a good job. I agree that the dependencies and GitHub actions must be updated.

But, since the code base don’t change, there is no good reason to drop support for old Python versions: stating that Pytest can’t test Python 2.7 anymore doesn’t mean the code base is not Python 2.7 compatible. Do you understand the idea?

I will find time to review your code.

colindean · 2023-03-20T22:47:17Z

Thank you kindly, @laurent-laporte-pro.

But, since the code base don’t change, there is no good reason to drop support for old Python versions: stating that Pytest can’t test Python 2.7 anymore doesn’t mean the code base is not Python 2.7 compatible. Do you understand the idea?

I think it's matter of representing what's tested. If the project represents that it's compatible with a version, it should be tested on it, esp. automated testing. Older Deprecated library versions remain compatible; only future releases could push someone toward a non-EOL Python version, a healthy practice for the ecosystem.

I think the changes I've made should facilitate re-adding the versions dropped. I could re-add the older versions to the testing matrix, but that could use a lot of CPU time for testing for Python versions that are insecure, out-of-date, and generally unused (with the exception of 2.7, which still has holdouts).

For me, getting Python 3.11 supported and tested is a top priority.

Mariatta · 2023-03-20T22:56:09Z

Perhaps this PR can be more focused about adding tests against Python 3.11. The parts about removing older Python support can be done as a separate PR. Or is there reason that we need to do it all at once?

colindean · 2023-03-21T00:16:22Z

This PR started as "coopt the existing Python 3.11 support patch and make it work" which turned into "drop the versions with tests that don't pass because of old CI setups" and settled on "hugely revised CI setup that drops old, unsupported versions and adds the new versions".

I could re-add the older versions to CI but I really don't want to spend much time in doing so beyond adding their strings to some lists in config files. I sank an afternoon into what's here as of 450dd3c.

hugovk · 2023-03-21T15:07:30Z

GitHub Actions has also dropped support for EOL Python 3.5-3.6:

Version 3.6 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

https://github.com/hugovk/deprecated/actions/runs/4480549799

tantale · 2023-04-28T13:06:06Z

setup.py

-        'Programming Language :: Python :: 2',
-        'Programming Language :: Python :: 2.7',
-        'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3.4',
-        'Programming Language :: Python :: 3.5',
-        'Programming Language :: Python :: 3.6',


Since the base code of this library has no change, I don't wan't to drop those versions.

tantale · 2023-04-28T13:10:48Z

setup.py

-    python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',
+    python_requires='>=3.7',


No, I want to keep this unchanged.

From my point of view, the reason that it is no longer possible to run unit tests with the recent tools is not a reason to abandon the support of Python 2.7 and the older versions of Python 3. If a user has an old development environment, he will be able to install and use the library.

But surely they could continue using the older releases of this package, if they still rely on python 2.7?

It won't break any user if they are stuck on an older version, because other packages are also not moving and there is no support/security-fixes anyways?

This PR does not change the code base, so the code remains compatible with older versions of Python. I don't want to make a major release for this PR: it's only a build fix.

If you're OK with allowing installation on an untested Python version, I'll revert the versions drop. I myself would not want to receive reports about any future failure on untested and EOL versions but I recognize the risk of breakage is low given that this library doesn't need to change much.

Researching a little deeper, I could retain testing on the older versions by switching the base platform for testing to

ubuntu-20.04 for 3.6 & 3.5

ubuntu-18.04 for 3.4

simply re-add 2.7 because there's a package for ubuntu-22.04 (which is ubuntu-latest) for 2.7.18

all of these per https://github.com/actions/python-versions/blob/main/versions-manifest.json

Looks like I can also enable 3.12.0-alpha - 3.12.0 through the semver hyphen ranges.

2.7 is being removed in a couple of weeks actions/runner-images#7401

Instead of 3.12.0-alpha - 3.12.0, we can use the simpler 3.12-dev. https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#using-the-python-version-input

Researching a little deeper, I could retain testing on the older versions by switching the base platform for testing to

ubuntu-20.04 for 3.6 & 3.5

ubuntu-18.04 for 3.4

simply re-add 2.7 because there's a package for ubuntu-22.04 (which is ubuntu-latest) for 2.7.18

all of these per https://github.com/actions/python-versions/blob/main/versions-manifest.json

Looks like I can also enable 3.12.0-alpha - 3.12.0 through the semver hyphen ranges.

I am OK with that.

tantale · 2023-05-27T16:12:13Z

Fixed in https://github.com/tantale/deprecated/releases/tag/v1.2.14

colindean · 2023-05-27T16:32:26Z

Thanks! Sorry I couldn't get around to massaging this PR to the desired state. It's been a busy few weeks.

hugovk and others added 7 commits November 6, 2022 14:23

Add support for Python 3.11

8c70e22

Bump checkout to v3 in CodeQL Analysis workflow

198870f

Drops Actions builds for Python 2.7, 3.5, 3.6; condense 3.7+

cc5c60f

Upgrades some actions versions in Actions python builds

8cc3832

Drops Python 2.7, 3.5, 3.6 builds from Travis; add 3.12

73a36f0

Drops Python older than 3.7 from the rest of things

208c2fd

Split and fix tox config for more better coverage

0d1d0ca

colindean commented Dec 16, 2022

View reviewed changes

colindean added 4 commits December 15, 2022 23:17

Adds importlib-metadata to dev deps

1827126

This may need to go into install deps…

Use newer Travis environment, Focal (Ubuntu 20.04)

fe8014d

Also fix error in pypy3 selection

Try installing importlib_metadata for tox run

0b84709

Limit tox to <4 on Travis because of outdatedness

d5926ba

tox-dev/tox-travis#160

colindean force-pushed the py311-redux branch from 5f83774 to d5926ba Compare December 16, 2022 05:25

colindean added 3 commits December 16, 2022 00:40

Adds Python 3.12 config to tox

9aad5c9

Use specifically pypy3.9 v7.3.9

bc42a86

Drop the .9 from pypy3 in tox.ini

97b7e06

colindean added 4 commits December 16, 2022 01:23

Drops old Pythons and adds newer ones for Appveyor build

e930748

Exclude pypy3 on ppc64le on Travis builds

74a386a

hugovk mentioned this pull request Jan 15, 2023

Support for Python 3.11 PyGithub/PyGithub#2377

Open

hugovk approved these changes Jan 15, 2023

View reviewed changes

hugovk mentioned this pull request Jan 15, 2023

Add support for Python 3.11 #58

Closed

colindean commented Jan 16, 2023

View reviewed changes

colindean added 2 commits January 15, 2023 20:10

Drops limitation on tox < 4 since bug was fixed

b452239

See tox-dev/tox-travis#160

Adds Pythons dropped notice to changelog

f01db11

colindean requested a review from hugovk January 16, 2023 01:12

hugovk reviewed Jan 16, 2023

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

colindean and others added 2 commits January 16, 2023 12:47

Fixes comment on which version is development branch

4658fe7

Co-authored-by: Hugo van Kemenade <[email protected]>

Drops seemingly unused importlib-metadata dev dep

450dd3c

hugovk approved these changes Jan 16, 2023

View reviewed changes

yozachar approved these changes Jan 20, 2023

View reviewed changes

tantale requested changes Apr 28, 2023

View reviewed changes

tantale approved these changes May 27, 2023

View reviewed changes

Merge branch 'master' into py311-redux

25f8de7

tantale approved these changes May 27, 2023

View reviewed changes

tantale closed this May 27, 2023

		py{37,38,39,310}-wrapt{1.10,1.11,1.12,1.13,1.14}
		py{311,312}-wrapt{1.14}

Wrapt version°	Pythons supported
1.10.x	2.6, 2.7, 3.3, 3.4, 3.5, 3.6
1.11.x	2.6, 2.7, 3.3, 3.4, 3.5, 3.6, 3.7
1.12.x	2.7, 3.4, 3.5, 3.6, 3.7, 3.8
1.13.x	2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10
1.14.x	2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11
1.15.x rc	2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11

		python_requires='>=2.7, !=3.0., !=3.1., !=3.2., !=3.3.',
		python_requires='>=3.7',

Support Python 3.11, drop older Pythons entirely #59

Support Python 3.11, drop older Pythons entirely #59

Conversation

colindean commented Dec 16, 2022

Choose a reason for hiding this comment

colindean commented Dec 16, 2022

colindean commented Dec 16, 2022

colindean commented Dec 19, 2022

hugovk left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hugovk left a comment

Choose a reason for hiding this comment

colindean commented Jan 16, 2023

colindean commented Feb 22, 2023

sbor23 commented Mar 16, 2023

laurent-laporte-pro commented Mar 20, 2023

colindean commented Mar 20, 2023

Mariatta commented Mar 20, 2023

colindean commented Mar 21, 2023

hugovk commented Mar 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tantale commented May 27, 2023

colindean commented May 27, 2023