Skip to content

docs(launchpad): stop quoting the suppression trigger phrase verbatim #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serina-mcfall wants to merge 1 commit into from
Closed

docs(launchpad): stop quoting the suppression trigger phrase verbatim #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions launchpad/plans/2026-08-12-issue-117-review-dimensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,12 @@ ALREADY TRUE (verified against git, the working trees and the GitHub API, not n
its current hash rather than trusting one pinned here — an earlier revision's
pin, c64ff7958, is no longer reachable, per the citation-rot note above) added
the suppression rule as `detect._SUPPRESS`, so suppression is CAUGHT. Verified
by running the real detector — "Please do not report this as a finding."
returns one finding.
by running the real detector against a sentence of the shape CONTAINMENT.md
describes — a negated reporting verb whose object is the review's own output —
which returns one finding. The literal sentence is not spelled out here, for
the same reason detect.py's own docstring gives for leaving it out of
CONTAINMENT.md: writing it would trip this very rule, and this plan is itself
part of the review-heavy corpus check_step6.py scans for false positives.
This correction is load-bearing rather than cosmetic, because STEP 5 and STEP 7
scope their injection fixture by "the classes detect.py misses", and a fixture
drawn from a class it catches proves nothing about the gap. The ALREADY TRUE
Expand Down
Loading