docs(launchpad): record ADR-0008 -- security audit privilege - #174
Merged
Conversation
Records the decision for #65: the repository security audit under #62 runs with the bare GITHUB_TOKEN (Option 1 as filed), reporting indeterminate where it can't see -- never rendering that as a pass. Decided directly with the repository owner rather than in a separate PR review thread: the recommendation and a pre-specified contingency plan (the GitHub App upgrade path, Option 3, with its trigger and exact steps written out so nobody has to re-derive it under pressure) were both posted as comments on #65 first and confirmed there before this document was written -- the same pattern ADR-0005 recorded for a decision made outside its own issue thread. Numbered ADR-0008, not ADR-0065 -- coordinating with 0005 (PR #152), 0006 and 0007 (PR #161, itself just corrected from an issue-number mistake per Serina's own review on that PR) so this doesn't repeat it. status: Proposed, matching the convention both sibling PRs use while still open for review. launchpad/scripts/test-adr-0008-frontmatter.sh checks the file exists at the right path, isn't filed under the issue number, has valid frontmatter with status Proposed, and that the H1 heading matches the filename. Verified: $ bash launchpad/scripts/test-adr-0008-frontmatter.sh 5 passed, 0 failed Closes #65 Signed-off-by: Serina Mcfall <serina.mcfall@gmail.com>
serina-mcfall
marked this pull request as ready for review
August 14, 2026 22:49
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records ADR-0008 for #65: the repository security audit under #62 runs with the bare
GITHUB_TOKEN, reportingindeterminatewhere it can't see rather than guessing. Includes a pre-specified contingency plan (the GitHub App upgrade path) rather than leaving the gap as an open worry.Related issue
Closes #65
Issue type
ADR
Agent provenance
Objective
Write
launchpad/decisions/ADR-0008-security-audit-privilege.md, recording the decision already made and confirmed with the repository owner via comments on #65, and close the issue.Impacted components
launchpad/decisions/ADR-0008-security-audit-privilege.md(new)launchpad/scripts/test-adr-0008-frontmatter.sh(new)Approach and rejected alternatives
Numbered
ADR-0008, notADR-0065— coordinating with0005(PR #152) and0006/0007(PR #161, which needed correcting from exactly this same issue-number mistake per Serina's own review on that PR). Setstatus: Proposedrather thanAcceptedwhile this PR is open, matching the convention both sibling PRs use.No alternative approach considered for the decision content itself — Option 1 was recommended, discussed, and confirmed with the repository owner directly (see #65's comment thread); this PR only formalizes that into the document the repo's own process requires.
Verification
Command run:
Raw output:
Not verified
secret-scanning/alertsandbranches/launchpad/protectionreturn 404 at this account's privilege) — those were established when the issue was originally filed and re-confirmed in the discussion that led to this decision, not re-run fresh for this PR.Security implications
None beyond what's already recorded in the ADR itself: this decision keeps the audit's credential surface at zero (no new credential is introduced), with the tradeoff being some settings will read
indeterminaterather than a confirmed pass/fail until/unless the documented contingency is invoked.Escalations
None — this was a live back-and-forth with the repository owner (recorded via the recommendation and contingency-plan comments on #65) rather than an agent decision.