chore(fixtures): throwaway — recording a rules-file-DELETE response (closing immediately) - #142
Closed
serina-mcfall wants to merge 1 commit into
Closed
chore(fixtures): throwaway — recording a rules-file-DELETE response (closing immediately)#142serina-mcfall wants to merge 1 commit into
serina-mcfall wants to merge 1 commit into
Conversation
…sponse Not for review and not for merge. Opened to record the DELETE direction of the nearest-rules fixture for the pre-flight in #116, because no real pull request in this fork or upstream deletes a rules file. Closed unmerged as soon as the response is recorded. Signed-off-by: Serina Mcfall <serina.mcfall@gmail.com>
Author
|
Recorded. Closing unmerged — this PR was only ever a fixture source for #116. |
serina-mcfall
added a commit
that referenced
this pull request
Aug 12, 2026
…inst Seventeen fixtures for #116, recorded from the live API by record.sh rather than written by hand. A hand-written fixture proves only that the code agrees with its author about the response shape. Three recorded facts differ from what the plan expected, and the controls follow the recording rather than the plan: - PR 86 now carries 47 checks with three named "check", not the 24 with two that the plan recorded a day earlier. Names collide harder than claimed, so the record must carry checks as a list. - Org-level rulesets answer 404, not 403, for a token without admin:org. launchpad-26 is an Organization, so that 404 hides access rather than reporting absence, and it cannot be read as "no rulesets exist". - PR 14 modifies root AGENTS.md and adds launchpad/AGENTS.md; the plan described both as additions. The ADD direction still has a real source. The DELETE direction has no real source in this fork or upstream, so it was recorded from throwaway PR #142, opened for the purpose and closed unmerged with its branch deleted. record-delete-fixture.sh is the audit trail. STEP 1's done-when is committed as eight controls rather than run once by hand, so a re-recording that drifts fails where the cause is legible. Refs #116 Signed-off-by: Serina Mcfall <serina.mcfall@gmail.com>
3 tasks
serina-mcfall
added a commit
that referenced
this pull request
Aug 12, 2026
…inst Seventeen fixtures for #116, recorded from the live API by record.sh rather than written by hand. A hand-written fixture proves only that the code agrees with its author about the response shape. Three recorded facts differ from what the plan expected, and the controls follow the recording rather than the plan: - PR 86 now carries 47 checks with three named "check", not the 24 with two that the plan recorded a day earlier. Names collide harder than claimed, so the record must carry checks as a list. - Org-level rulesets answer 404, not 403, for a token without admin:org. launchpad-26 is an Organization, so that 404 hides access rather than reporting absence, and it cannot be read as "no rulesets exist". - PR 14 modifies root AGENTS.md and adds launchpad/AGENTS.md; the plan described both as additions. The ADD direction still has a real source. The DELETE direction has no real source in this fork or upstream, so it was recorded from throwaway PR #142, opened for the purpose and closed unmerged with its branch deleted. record-delete-fixture.sh is the audit trail. STEP 1's done-when is committed as eight controls rather than run once by hand, so a re-recording that drifts fails where the cause is legible. Refs #116 Signed-off-by: Serina Mcfall <serina.mcfall@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not review. Do not merge. Closing as soon as two API responses are recorded.
This PR exists only so that #116 can record what the compare
and tree endpoints return for a pull request that deletes the nearest rules
file for a path it also touches. No PR in this fork's history does that, and
none was found upstream, so the add direction (PR #14, real) would otherwise
have had to stand in for both by assertion.
Refs #116